Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370402

Summary: misleading state of tracing preference
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Curtis Windatt <curtis.windatt.public>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public
Version: 3.8Flags: daniel_megert: review+
Target Milestone: 3.8 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Dani Megert CLA 2012-02-02 03:13:36 EST

    
Comment 1 Dani Megert CLA 2012-02-02 03:14:32 EST
3.8 M5.


When I start with -debug and an options file that has tracing options enabled, it looks weird that the tracing preference is not enabled.
Comment 2 Curtis Windatt CLA 2012-02-08 17:47:06 EST
Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=ab9201ae04a5041963ec5c9e836a8617090771bd

I took a different approach.  If you launch with -debug/options, the preference page gives you a warning.  If you want to override, you can check the enable button on the page and we use your previous preference settings. If you restart with -debug mode, we put the warning back.  If you restart without -debug mode we continue to use the preference settings.

I think this is a good solution because we always use the launch -debug/options if available and doing so does not destroy any existing settings.

Dani, please let me know what you think.
Comment 3 Dani Megert CLA 2012-02-09 08:00:40 EST
> Dani, please let me know what you think.

I like it!

The wording of the text seems wrong though: AFAIK there's only one options file being passed with -debug.

"printed to system output stream" sounds too technical.

Reopening so we don't forget about the label.
Comment 4 Dani Megert CLA 2012-02-09 08:04:00 EST
.
Comment 5 Curtis Windatt CLA 2012-02-09 12:21:51 EST
New strings are as follows:

Modify the tracing options that a plug-in offers.

This application was launched in debug mode with a tracing options file. You can override the current settings by enabling tracing below.