Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370390

Summary:	RWT should have a LoginDialog
Product:	[RT] RAP	Reporter:	Elias Volanakis <elias>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	austin.riddle
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Elias Volanakis

2012-02-01 22:24:26 EST

Many applications have some sort of log-in.

Since one of our guiding mottos is making web-development a 'first class' citizen in RAP, we should add a LoginDialog to RWT.

This could be similar to the LoginDialog from o.e.r.demo.controls, refactored to:
- remove JFace dependencies
- add a #setPassword(...) method (useful during development)

If there is interest, I'm happy to provide this.

Comment 1 Ralf Sternberg

2012-02-02 06:26:50 EST

Sounds good, although I'd see this as an add-on that we can refer to from the RAP project page.
If you create it, this would be fine, if you agree to maintain it, this would be even better!
Why don't you start the thing on github, then we can discuss where to host it.

Comment 2 Elias Volanakis

2012-02-02 13:25:51 EST

Is there any reason for not having it in RWT?

Having it in RWT is important to me. The reason is that I would like to use this in trainings, without having to provide additional components or dependencies (other than org.eclipse.rap.rwt).

If we treat it as an add-on, there is already a LoginDialog in org.eclipse.rap.demos that I can use...

Comment 3 Austin Riddle

2012-02-02 13:55:45 EST

(In reply to comment #2)
> Is there any reason for not having it in RWT?

Ever since I have started in RAP I have wanted a readily accessible login dialog.  And I used to think that it should be a part of RWT. However, as I now have had more experience in developing applications for clients I have realized that it is something very much dependent upon the application and client.  Some want the login to look like most web pages, where credentials are specified in an embedded place on the page with their header/footer, etc., some want a dialog, but want their logo prominently displayed, most want password reset links, etc.  And more professional organizations want to authenticate using LDAP or active directory, or via a portal. It is not a one size fits all topic. In my mind, the RWT widgets we have in the bundle now are really meant to overcome certain specific limitations with the toolkit. And they are written to be more general solutions.

I would personally like to see another supplemental bundle in the incubator that could provide a few differing options for accepting credentials.

Comment 4 Ralf Sternberg

2012-02-03 05:41:51 EST

(In reply to comment #2)
> Is there any reason for not having it in RWT?

I fully agree with Austin about the many different types of login dialogs. Someone else will demand for a login dialog with language selection, captchas, registration form, and what not. RWT is the core of the framework and should provide the building blocks, not things that are assembled from it. Exceptions are those dialogs that are also present in SWT because they build on operating system components on the desktop.

Moreover, the RAP core team is already fully occupied with the work on RAP itself, we cannot take over responsibility for add-ons. However, I would like to add a page to our project site called "Add-ons" and collect all those components there.

Comment 5 Elias Volanakis

2012-02-03 13:28:44 EST

Austin, Ralf, I do agree with your reasoning.

However, providing an add-on was not my intention (since I can already use the LoginDialog from o.e.r.demos in my training), so I'm closing this as WONTFIX. 

Feel free to open a new bug for a LoginDialog as an add-on.