Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370292

Summary:	git-log page: "Open" is not working
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2012-01-31 23:42:55 EST

1. Go to the git-log view for a file.
2. Click the "open" link beside one of the commits.
3. You're taken to an empty editor page.

The URL that does not work looks like this:
http://orion.eclipse.org:8080/edit/edit.html#/gitapi/commit/882a25d4dc4783db09592a267b4301fd08643b49/file/G/bundles/org.eclipse.orion.client.core/web/index.js?parts=body

May be related to recent changes to editor parameters

Comment 1 Szymon Brandys

2012-02-01 04:00:17 EST

What changes in editor parameters? Who made them?

Comment 2 Szymon Brandys

2012-02-01 04:12:36 EST

I remember that the editor used to work even if no metadata was provided by the resource (i.e. parts=meta was not supported). Could we fix the editor so it works the old way?

Comment 3 Mark Macdonald

2012-02-01 10:29:11 EST

(In reply to comment #2)
> I remember that the editor used to work even if no metadata was provided by the
> resource (i.e. parts=meta was not supported). Could we fix the editor so it
> works the old way?

Ah... then the culprit is probably setup.js. It needs to handle the no-metadata case.

Comment 4 Mark Macdonald

2012-02-01 23:53:10 EST

Released
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=562dfccb9f80f0851b13b9b0b84dcec6500f8eaa

This lets you view the file in the editor. Because we have no metadata (even the filename is unknown) all you get is a plain editor. The relevant commands, breadcrumb, highlighting, outline, etc, are not provided.

Also: I noticed the editor being opened is writable. It really should be readonly. However, readonly.html appears to be broken... I'll open a separate bug for that