Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370032

Summary:	Go up command is not working when in top level folder
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw
Version:	0.4	Flags:	libingw: review+
Target Milestone:	0.4 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-27 20:53:53 EST

If you are in a top level folder, the Go Up command doesn't take you to "Orion Projects".  I thought this was working, i remember testing it.

Of course it shouldn't show up in the toolbar when at the very top.

Comment 1 Susan McCourt

2012-02-14 14:35:06 EST

Fix is available at remote branch
origin/bug370032 

The problem is that item.Parents is empty when you are a top level project, so we need special code to return a workspace root for that case.  I had to add API to fileClient to support this, but I think it's a reasonable thing to add.

I tested for the default file system.  We know that the file system root property works for other systems (webdav) because this is the location used on the navigation outliner when multiple file systems are present.  

(See also bug 370897 for related issues with file system roots and parents)

Libing, can you review?

Comment 2 Susan McCourt

2012-02-14 15:45:47 EST

Libing pointed out that the new fileClient API is not necessary since we map "#" to mean "root location of file system" in the navigator.  So the fix is much simpler.

Here is a new fix, the last commit in the branch
origin/bug370032better 

Libing, can you review again?

Comment 3 libing wang

2012-02-14 15:58:15 EST

The code looks good to me and behaves consistently with key board left key navigation on both Orion and web dav file systems.
+1.

Comment 4 Susan McCourt

2012-02-14 16:03:01 EST

pushed.  thanks again, Libing!