Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370022

Summary:

Skip All Breakpoints tool should not have mnemonic in tooltip

Product:

[Eclipse Project] Platform

Reporter:

Carolyn MacLeod <carolynmacleod4>

Component:

Debug

Assignee:

Pawel Piech <pawel.1.piech>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Michael_Rennie

Version:

4.2

Target Milestone:

3.8 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Screen snap of Java and Debug toolbars	none

Description Carolyn MacLeod

2012-01-27 17:46:50 EST

Build id: I20120126-1300

This is a problem in both 3.8 and 4.2.

I assume that the "Skip All Breakpoints" tool in the main toolbar is being contributed by the debug plugin? (Apparently Plug-in Spy doesn't find tool items).

The tooltip has an & in it for a mnemonic (i.e. "S&kip All Breakpoints"), however tool items do not need mnemonics (they may have shortcut keys, aka accelerators, however they do not have mnemonics). Also, screen readers use the tool item's tooltip to tell the user the name of the tool item, and it sounds like "S-and-kip All Breakpoints".

(Just curious - this tool item seems a little out of place. Shouldn't it be grouped with the Run/Debug tools?)

Comment 1 Pawel Piech

2012-02-22 23:38:03 EST

Thank you for pointing it out.  For whatever reason I don't see the mnemonic on linux/gtk. 

I committed the fix: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=2253307b7a0515c567b2e4449f97636c85348cc7

(In reply to comment #0)
> ...
> (Just curious - this tool item seems a little out of place. Shouldn't it be
> grouped with the Run/Debug tools?)

Not sure what you mean.  In the debug perspective, the action follows run control actions.  It's also enabled in the java perspective, where they follow the launch actions.  Do you see something different?

Comment 2 Carolyn MacLeod

2012-02-23 01:04:36 EST

Created attachment 211469 [details]
Screen snap of Java and Debug toolbars

> Thank you for pointing it out.
You're welcome. Thanks for fixing it.  :)

>> (Just curious - this tool item seems a little out of place. Shouldn't it be
>> grouped with the Run/Debug tools?)

> Not sure what you mean.  In the debug perspective, the action follows run
> control actions.  It's also enabled in the java perspective, where they
> follow the launch actions.  Do you see something different?

I've attached a snap of what I see. Would be nice if "Skip All Breakpoints" was in the same toolbar as Run and Debug. I think the best place is right after the Debug tool. Looks funny all by itself in its own toolbar and separate from the Run/Debug tools.  I did not do anything strange when I installed Eclipse - this is a standard install. (Eclipse 4.2)

Comment 3 Pawel Piech

2012-02-23 10:06:00 EST

Oops, I missed one file in my last commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=8a8b76467672e3c5de49ffacf204ac120b806cc0


(In reply to comment #2)
> I've attached a snap of what I see. Would be nice if "Skip All Breakpoints" was
> in the same toolbar as Run and Debug. I think the best place is right after the
> Debug tool. Looks funny all by itself in its own toolbar and separate from the
> Run/Debug tools.  I did not do anything strange when I installed Eclipse - this
> is a standard install. (Eclipse 4.2)

I see, the debug toolbar location is specified as "locationURI="toolbar:org.eclipse.ui.main.toolbar?after=additions".  The result is that it's placed differently on e4 and 3.8.  If you don't mind, please file a new bug.

Comment 4 Carolyn MacLeod

2012-02-23 16:45:13 EST

I opened bug 372424. Thanks!