Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369989

Summary: User feedback for plugin installation
Product: [ECD] Orion Reporter: John J. Barton <johnjbarton>
Component: ClientAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: grant_gayed, simon_kaegi
Version: 0.4   
Target Milestone: 2.0 RC1   
Hardware: All   
OS: All   
Whiteboard:

Description John J. Barton CLA 2012-01-27 13:41:11 EST
1. Click Installed Plugins on Orion toolbar
2. Enter http://www.google.com in the text box
3. Click install.

Feedback (way way down in the bottom corner!) says "installing..." then later it says 

Load timeout for plugin: http://www.google.com

It should say: 

 http://www.google.com is not an Orion Plugin

--------
Try the same thing with

http://localhost:8080/file/J/bundles/org.eclipse.orion.client.debug/web/debugPlugin.html

It stays "installing..." that is it no more feedback at all.
Comment 1 Simon Kaegi CLA 2012-10-04 16:28:20 EDT
Doing nothing more for 1.0 -- we now timeout after 5 seconds so at least the user knows there was a problem faster. The problem here is that we know very little about the success or failure of the content loaded in an iframe. e.g. we don't know if we got a 404 or if the page is indeed an html page but does not support the Orion plugin protocol.
Comment 2 Simon Kaegi CLA 2013-01-30 15:41:53 EST
We still have very limited information however we can now handle two distinct error cases (and we don't ever leave the user in a forever installing... status)

We now handle cases:
1) Where we get a 404 - by returning a failed to load message
2) Where the page loaded but did not do the plugin handshake - by returning a failed to perform plugin handshake message.