Bugzilla – Full Text Bug Listing
| Summary: | Operations icon not shown when there is no status message | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | susan, Szymon.Brandys |
| Version: | unspecified | ||
| Target Milestone: | 0.4 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 370782 | ||
|
Description
Malgorzata Janczarska
ok, we'll try to find a better home for this, maybe some kind of animating icon that doesn't necessarily live next to the messages...I never realized til your explanation here what the case was where there was an icon and no progress, I find it happens quite a lot where you have that yellow icon and don't really know what it's telling you. Just to clarify: does that icon show when there's *any* operation (from any page) or is it just showing when the operation launched from the current page is running? If it's the former, then we need it to be very subtle... I made a quickie fix for M2 that will put it on the right of the toolbar near the status area. This may turn out to be a good home for it, maybe we just need to make sure the icon is cleaned up (I will make sure this happens, we are still working out which icons will have the yellow...) Thanks! (In reply to comment #1) > Just to clarify: does that icon show when there's *any* operation (from any > page) This case. > If it's the former, then we need it to be very subtle... We have a way to tell if the operation is run on this page (since the last reload) or others, so there would be a possibility to make it more subtle if there are no operations from this page and lass subtle if there are any operations run recently by this page. But in general I agree that it should be subtle. I pushed a change for now that uses the existing eclipse animated "busy" icon when there a task icon running, and a subdued version of that icon when there is nothing running. Note there is not yet a corresponding change to the error/warning versions of those icons (but I haven't noticed them popping up either). I think it looks a lot better, and having the icon now in the toolbar on the right seems like a good spot. (When it was on the right up in the banner it seemed much too prominent, but moving it by the progress message didn't really play well either). What do you think, Gosia? If you are happy with the placement I think we can close this bug and then we are just needing to get icons. We can track the icon itself in bug 364399. I like the placing of the icon now, only git status page is a problem. Always on loading the status page I get the icon hidden under the slider. I like the idea of having an animation when there are some tasks running.(In reply to comment #4) > Note there is not yet a corresponding change to the > error/warning versions of those icons (but I haven't noticed them popping up > either). This looks a little odd now, but I understand that this is temporary and we'll change it when we have icons drown in bug 364399. i'll mark this fixed and we can address git status separately. I noticed today running self hosted that it was better, the icon was always visible, although there's no padding. We'll fix as part of making git status align more with other pages. Can you think of an easy scenario where I can see the "task/error" or "task/warning" in action? just curious. (In reply to comment #6) > Can you think of an easy scenario where I can see the "task/error" or > "task/warning" in action? just curious. Try to push to repository when there are no outgoing commits. Try also to merge where there are no incoming commits. To get an error try to clone repository that does not exist or you have no permissions to. (In reply to comment #7) > (In reply to comment #6) > > Can you think of an easy scenario where I can see the "task/error" or > > "task/warning" in action? just curious. > Try to push to repository when there are no outgoing commits. Try also to merge > where there are no incoming commits. To get an error try to clone repository > that does not exist or you have no permissions to. cool, thanks, that helps me make screenshots for icon designers. |