Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369969

Summary:	Propagate project text label decoration up to working set
Product:	[Technology] EGit	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Gunnar Wagenknecht <gunnar>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	gunnar, markus.duft, matthias.sohn, robin
Version:	1.3
Target Milestone:	2.2-M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Markus Keller

2012-01-27 11:49:56 EST

follow-up to bug 344937

Icon decorations are now propagated to the enclosing working set, but the text label decorations of projects in the working set are not.

The Eclipse CVS client also propagated the project text label decoration (e.g. the branch name) to the working set iff all shared projects in the working set had the same decoration.

Unshared projects should not influence the decoration, but shared projects from other repository providers should stop the decoration.

Top-notch would be if this even worked cross-repository, e.g. decorations
[egit master] and [jgit master] would be merged into [ master] or [* master].

Comment 1 Markus Duft

2012-01-30 08:32:59 EST

how would this look like for working sets with multiple projects from multiple repos that have multiple differently named branches checked out...?

Comment 2 Markus Keller

2012-01-30 09:25:45 EST

> how would this look like for working sets with multiple projects from multiple
> repos that have multiple differently named branches checked out...?

Depending in what you choose for "no unique value", it could be " [* *]", or
" [ ]", or "" (nothing).

For CVS projects, the working set shows the tag/branch iff all shared projects in the working set use the same tag/branch name -- otherwise, it shows nothing. The CVS label decoration on working sets always shows the tag/branch and cannot be configured.

I think EGit should do better and use the "Projects" decoration for working sets. As soon as the value of a variable is not the same for all projects, don't show that info any more or replace it with a "*".

Comment 3 Gunnar Wagenknecht

2012-10-20 07:01:13 EDT

Created Review
  https://git.eclipse.org/r/8321

The proposed change uses the same logic observed with CVS decorations, i.e. as soon projects from different repositories and/or different branches are discovered, no decoration is shown.

Please review.

Comment 4 Matthias Sohn

2012-11-02 19:32:13 EDT

merged as ba68aa691289343b2af9acd1fa8c658a49c58d92

Comment 5 Robin Stocker

2012-11-05 08:07:37 EST

Added to new and noteworthy for 2.2:

http://wiki.eclipse.org/EGit/New_and_Noteworthy/2.2#Working_set_project_decorations