Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369966

Summary: JavaFacetUtil needs to be updated to include Java 7
Product: [WebTools] WTP Webservices Reporter: Keith Chong <keith.chong.ca>
Component: jst.wsAssignee: Keith Chong <keith.chong.ca>
Status: RESOLVED FIXED QA Contact: Keith Chong <keith.chong.ca>
Severity: normal    
Priority: P3 CC: cbridgha, ccc, neil.hauge
Version: 3.3.1Flags: keith.chong.ca: pmc_approved? (david_williams)
keith.chong.ca: pmc_approved? (raghunathan.srinivasan)
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (deboer)
cbridgha: pmc_approved+
keith.chong.ca: pmc_approved? (kaloyan)
keith.chong.ca: pmc_approved? (cbridgha)
Target Milestone: 3.3.2   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_Approved
Bug Depends on: 369959, 369967    
Bug Blocks:    
Attachments:
Description Flags
Apply to org.eclipse.jst.ws.consumption none

Description Keith Chong CLA 2012-01-27 11:41:19 EST 
+++ This bug was initially created as a clone of Bug #369959 +++

Currently, the highest java facet version it supports is Java 6.  (JavaFacet.JAVA_60)

There is a JavaFacet.VERSION_1_7 that should be added.

Open bug for WTP 3.3 maintenance branch.
Comment 1 Keith Chong CLA 2012-02-01 13:37:41 EST 
Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.
This is required for Java 7 support.

Is there a work-around? If so, why do you believe the work-around is insufficient? 
No workaround

How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
This has been manually tested for the same fix against 3.2.5.

Give a brief technical overview. Who has reviewed this fix?
It's a simple fix, adding an extra condition to consider Java 7 (see patch)

    else if (jdkComplianceLevel.equals("1.7"))
    {
      javaFacetVersion = JavaFacet.VERSION_1_7;
    }


What is the risk associated with this fix? 
Low risk.
Comment 2 Keith Chong CLA 2012-02-01 13:39:52 EST 
Created attachment 210393 [details]
Apply to org.eclipse.jst.ws.consumption

Same patch as for 369959.  Version update to plugin not required.
Comment 3 Keith Chong CLA 2012-02-01 13:42:00 EST 
Seeking PMC approval for this fix for WTP 3.3.2.
Comment 4 Keith Chong CLA 2012-02-01 15:23:57 EST 
Thanks Neil.
Comment 5 Chuck Bridgham CLA 2012-02-02 09:19:35 EST 
This was approved yesterday..
Comment 6 Keith Chong CLA 2012-02-02 13:39:57 EST 
Resolving.