Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369890

Summary:	scroll bar issues in left hand panes
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	aclement, john.arthorne
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-26 22:11:48 EST

with all the structural and styling changes for the new look, I think some old "overflow" bugs are back.  For example:

- left hand pane in navigator has a vertical scrollbar even when not needed.  If you expand/collapse the splitter, it fixes itself.  I remember having to add code to eWebBorderContainer to remember and reset overflow back in 0.2.  Check old bugs and code history.

- git status left hand pane does not grow the vertical scrollbar when the git logs come in, so you can't scroll until you resize.

- unrelated but weird:  it seems like the ewebbordercontainer collapse arrows are
reversed.

Comment 1 Susan McCourt

2012-01-27 13:49:23 EST

*** Bug 369971 has been marked as a duplicate of this bug. ***

Comment 2 Andrew Clement

2012-01-27 20:07:20 EST

I had a look at some of this.

> - left hand pane in navigator has a vertical scrollbar even when 
> not needed.  If you expand/collapse the splitter, it fixes itself. 
>  I remember having to add code to eWebBorderContainer to 
> remember and reset overflow back in 0.2.  Check old bugs 
> and code history.

this appears to be the code in the eWebSplitter._handleOnChange
function.  It is copied from ToggleSplitter I think and retains this
bit:

var styleProps = dojo.mixin({
  display: "block",
  overflow: "auto",
  visibility: "visible"
}, this._openStyleProps);

The inclusion of overflow:auto appears to override the hidden
settings specified elsewhere (css).  If you remove the overflow
line there, it behaves correctly.  There is no duplicate vertical
scroll bar. (the scrollbar from the internal content pane is used)

I've got a commit for it, but it feels overkill for just removing
that one line!

git repo: https://github.com/aclement/orion.client
branch: bug369890
commit id: 419dee775f587b02c581f0e9e8c8cf86b35a7f84
full link: https://github.com/aclement/orion.client/commit/419dee775f587b02c581f0e9e8c8cf86b35a7f84

I'm no expert on this area of the code though so might be wrong, but that change did fix it for me.

> - unrelated but weird:  it seems like the ewebbordercontainer collapse arrows
> are reversed.

I know what you mean - I puzzled over this for a while but eventually concluded that the arrow was reflecting the state of the pane, not what would happen if you click on it.  (so it was a right arrow icon when open and a left arrow icon when closed).   (if that is what you were seeing...)

Comment 3 Susan McCourt

2012-01-31 13:47:11 EST

(In reply to comment #2)
> I had a look at some of this.

> I've got a commit for it, but it feels overkill for just removing
> that one line!

Yes, but a well placed line makes all the difference!  Thanks for looking into this.  The code I was remembering adding had to do with remembering the current overflow on close and restoring on open.  You are right that the other part was subverting the attempt to honor the original CSS.  I pushed the fix.  Thanks again!

> I know what you mean - I puzzled over this for a while but eventually concluded
> that the arrow was reflecting the state of the pane, not what would happen if
> you click on it.  (so it was a right arrow icon when open and a left arrow icon
> when closed).   (if that is what you were seeing...)

Yes.  They should show you what will happen.  I think the current way is not intentional, it's one of those toggle things that's easy to get wrong when the names are things like "open/closed" or "left/right" rather than "openIt/closeIt" or "moveLeft/moveRight".  I swapped the images in the CSS.

Comment 4 Susan McCourt

2012-01-31 13:48:12 EST

fixed.
Tested on Chrome 16, FF 9, IE9