Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369862

Summary:	Remove all calls to SpringCore.log()
Product:	[RT] Virgo	Reporter:	Leo Dos Santos <leo.dos.santos>
Component:	tooling	Assignee:	Miles Parker <milesparker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse, milesparker, mlippert
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:
Bug Blocks:	341910

Description Leo Dos Santos

2012-01-26 14:57:46 EST

Virgo Tools is routing most of its exception logging through Spring IDE, although this is unnecessary. We should be logging our exceptions through Virgo IDE's StatusHandler class. We might need to move StatusHandler to a non-UI plugin so that it can be called from the rest of the tools.

Comment 1 Miles Parker

2012-01-26 21:23:13 EST

OK, this is fixed in the commits below. Please note that you may need both commits. I screwed up the header on two files again. Also, the naming refactorings are on this branch. I don't know if you can get these changes without getting those. If not, I'm going to have to try to do some git magic to get a cleaner version of the changes.

https://github.com/MilesParker/Virgo-Tooling/commit/f2de005e219a354f804e5a07719e23a5a418365f
https://github.com/MilesParker/Virgo-Tooling/commit/c1031073b6e953dbe519d031aeea0ba67c79e41a

Comment 2 Leo Dos Santos

2012-01-27 13:34:21 EST

Hi Miles

I'm unable to cherry-pick these changes without also applying the externalization work in your repo, so you'll have to some magic after all.

Try to compartmentalize your changes a bit so that your patches are leaner. For example, this bug should really only see the SpringCore.log() replacements, and bug 369862 should only see the JdtUtils.getJavaProject() changes. Create a separate bug to adopt the Virgo commons APIs and add a patch for that. What ever is left over can be posted to parent bug 341910 and we'll figure if & how the patch can be broken down further.

Good luck.

Comment 3 Miles Parker

2012-01-27 18:14:00 EST

OK, here's the clean commit:

https://github.com/MilesParker/Virgo-Tooling/commit/18188c849f05e6ba17e5721686e2a0acc93d1750

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.

Comment 4 Leo Dos Santos

2012-01-27 19:44:14 EST

I had to apply this patch concurrently with the patch to bug 370023 comment 1 in order to pull in StatusUtils. 

Miles' changes:
http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=d984eeba6f5730e989ecb6abd71ac05b3f92e7ee
http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=eaf8f1217a19e6b2a54f6cd9907928721838ed49

I made some additional changes to fix up some strings that shouldn't have been externalized:
http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=0df5e19068ce2798ad495b0c66015a9b3fe7ef8e

Thanks again Miles!