Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369861

Summary: Replace all calls to Spring IDE's JdtUtils.getJavaProject()
Product: [RT] Virgo Reporter: Leo Dos Santos <leo.dos.santos>
Component: toolingAssignee: Miles Parker <milesparker>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse, milesparker, mlippert
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 341910    

Description Leo Dos Santos CLA 2012-01-26 14:57:44 EST
There are several references in Virgo Tools to Spring IDE's JdtUtils.getJavaProject(IProject), JdtUtils.getJavaProject(IResource). We need to write alternatives into a Utils class of our own, and call those instead.
Comment 1 Miles Parker CLA 2012-01-26 21:24:01 EST
Same comments apply. This covers both bugs.

OK, this is fixed in the commits below. Please note that you may need both commits. I screwed up the header on two files again. Also, the naming refactorings are on this branch. I don't know if you can get these changes without getting those. If not, I'm going to have to try to do some git magic to get a cleaner version of the changes.

https://github.com/MilesParker/Virgo-Tooling/commit/f2de005e219a354f804e5a07719e23a5a418365f
https://github.com/MilesParker/Virgo-Tooling/commit/c1031073b6e953dbe519d031aeea0ba67c79e41a
Comment 2 Leo Dos Santos CLA 2012-01-27 13:35:17 EST
See my comments on bug 369862
Comment 3 Miles Parker CLA 2012-01-27 15:03:23 EST
OK, let's give this a try. I've cleaned up any history here.

https://github.com/MilesParker/Virgo-Tooling/commit/ff79ddb09f9251686f1abdbc048a7b99bf9500d9
Comment 4 Miles Parker CLA 2012-01-27 18:14:12 EST
I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 5 Leo Dos Santos CLA 2012-01-27 18:23:41 EST
Thanks Miles. This takes us one step closer being Spring IDE free! Your changes were committed here:
http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=2164ede63b1fa5cdd03b9684fad7fe8c61e08e9e

I made few modifications upon reviewing the code. Mainly readding the propertyTester extension in one of the plugin.xml's and removing the StatusUtil change from DeefaultServerDeployer:  
http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=6a3b40f7cb5a553399dc971bc0095b82ac430d6b