Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369857

Summary:	settings, git-repository, git-clone pages are not optimized
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Releng	Assignee:	Project Inbox <orion.releng-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	All
Whiteboard:

Description Mark Macdonald

2012-01-26 14:12:50 EST

orion.eclipse.org running I20120125-2230

1. Go to one of these pages:
  /settings/settings.html
  /git/git-repository.html
2. View the network log. You'll see that the page is not as a single optimized .js file, but instead loads all its dependencies individually.

Comment 1 Mark Macdonald

2012-01-26 15:19:56 EST

The build logs [1] show that the optimizer failed on git-repository.
The settings page just needs to be added to the build script.

Comment 2 Mark Macdonald

2012-01-26 15:20:19 EST

(In reply to comment #1)
> The build logs [1] show that the optimizer failed on git-repository.
> The settings page just needs to be added to the build script.

[1] http://download.eclipse.org/orion/drops/I201201251525/buildLog-I20120125-1525.txt

Comment 3 Mark Macdonald

2012-01-26 15:43:58 EST

The optimizer uses Rhino, which was getting parse errors on our code. Fixed here:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=619f5b66bafd8a33fbfc5f53b1ac8bb014484566

Added settings page to the build script:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=3ce98bd4a510bdb3b633d269ebe5cba39138489a