Bugzilla – Full Text Bug Listing
| Summary: | Date (format) in History view is not user-friendly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | markus.kell.r, matthias.sohn, raue, robin.rosenberg, robin | ||||
| Version: | 1.3 | ||||||
| Target Milestone: | 3.6 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 419573 | ||||||
| Attachments: |
|
||||||
|
Description
Dani Megert
Created attachment 210113 [details]
Picture
I heard the argument that the timezone is shown to get the "Git" feeling, but if I look at other places in EGit (e.g. Commit viewer, commit area in History view) , the timezone is never shown. Why is it a must in the History view? If we want to keep the timezone, then I suggest to add an option to hide the timezone. Ping! It is really a pain to parse the date in the History view. Please take a look at the picture. "User friendly" is very subjective, so that is not helpful is fixing something. How about displaying time on the committer's timezone, omitting timezone if it happens to be the user's local time zone? (In reply to comment #5) > "User friendly" is very subjective, so that is not helpful is fixing something. So, are you saying, that you can quickly and easily read the dates in the attached picture and bring them into a time sequence? I can't. > How about displaying time on the committer's timezone, omitting timezone if it > happens to be the user's local time zone? I would simply like to see the date/time like it is already shown in the commit editor (yes, it already works there as expected/desired :-) and converted to my local timezone, so that I don't have to compute it myself. I think the best is to make it configurable because this is really a matter of taste. There is no one-size-fits-all. Note that there is already something along those lines on the Git > Label Decorations | Other preference page. Still major. (In reply to Robin Rosenberg from comment #5) > "User friendly" is very subjective, so that is not helpful is fixing > something. No. Dani gave objective reasons why using the committer's time zone is not user-friendly: Comparing timestamps from different time zones is an undue burden. There are two reasonable formats: 1. local time zone (rendered without +/-ZZZZ) => to be used wherever it's likely that the user needs to compare times 2. original time zone (rendered with +/-ZZZZ) => can be shown as additional info when a "long"/"original" format is desired The History view should just use the local time zone. Or at least a configurable time format (though I don't know any place in EGit where the format from Label Decorations is actually used). The original times can be shown in the History view's preview, or in a tooltip in the commit editor. Proposed implementation: https://git.eclipse.org/r/36624 Shows date in local time zone in column, and date in original time zone on hover (in ISO format). There is disagreement on the review about how the date with time zone *in the tool tip* should be formatted. The change uses ISO 8601 format, which looks like this (regardless of locale): 2014-11-10 16:34:54 +0100 Matthias would like it to be the locale date format with time zone, which looks like this: DE: 10.11.2014 16:34:54 +0100 US: Nov 10, 2014 4:34:54 PM +0100 I like ISO because it's unambiguous and frequently used for showing international times, and most if not all developers should be familiar with it. And showing a locale-specific format with a time zone feels strange to me. But I see the argument that using a different format in the tool tip can be confusing. What do you think? merged as 0c4bf7ab1a71230e1a8a6d6eda7cd6d3aef2d31f |