Bugzilla – Full Text Bug Listing
| Summary: | RDTFileProxy needs improved error handling when a URL contains a bad connection id | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Corey Ashford <cjashfor> | ||||
| Component: | Project | Assignee: | Linux Distros Inbox <linux.distros-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | jjohnstn, obusatto | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
This patch works for me. Can I apply it? Or is there something to fix? (In reply to comment #1) > This patch works for me. Can I apply it? Or is there something to fix? Patch is fine. For iplog approval, Corey needs to state here that he developed the patch 100% and had permission to do so from his employer and that the changes are EPL. After that, the patch can be applied as it is <250 lines. (In reply to comment #2) > (In reply to comment #1) > > This patch works for me. Can I apply it? Or is there something to fix? > > Patch is fine. For iplog approval, Corey needs to state here that he developed > the patch 100% and had permission to do so from his employer and that the > changes are EPL. After that, the patch can be applied as it is <250 lines. I developed this patch 100% and had permission from my employer, IBM Corp., to do so. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > This patch works for me. Can I apply it? Or is there something to fix? > > > > Patch is fine. For iplog approval, Corey needs to state here that he developed > > the patch 100% and had permission to do so from his employer and that the > > changes are EPL. After that, the patch can be applied as it is <250 lines. > > I developed this patch 100% and had permission from my employer, IBM Corp., to > do so. Also, the changes I made are intended to be EPL. Comment on attachment 210094 [details]
Patch that improves error handling of URLs containing bad connection ids
Patch under 250 lines.
Patch applied and modified slightly. The PTP plugin should not be referenced on an exception created by this plug-in. I have modified the exception to use the RDT proxy plug-in id. I also modified the exception to use NLS for the error message. |
Created attachment 210094 [details] Patch that improves error handling of URLs containing bad connection ids If you try to manufacture an IRemoteFileProxy for a URL which uses either the remotetools or rse scheme, you will get an NPE in IRemoteFileProxy