Bugzilla – Full Text Bug Listing
| Summary: | Current linebreaks from help message of the CDOCommandProvider doesn't work under windows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] EMF | Reporter: | Heiko Techteam <techteam> | ||||
| Component: | cdo.core | Assignee: | Eike Stepper <stepper> | ||||
| Status: | CLOSED FIXED | QA Contact: | Eike Stepper <stepper> | ||||
| Severity: | trivial | ||||||
| Priority: | P3 | CC: | Ed.Merks, stepper | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
How excatly can I reproduce your problem? I'm also working on Windows but the Eclipse console doesn't seem to have any issues with the line breaks as they are. I'm reluctant to make line breaks specific to any kind of OS. Wouldn't that mean that soon other users would complain it doesn't work on, e.g., Linux anymore? In general, how can a server provide a client with the needed line breaks without knowing what OS this client is running on? All this makes me think you've just not found the proper line ending conversion settins in your console client. To reproduce the problem(I've the problem at a windows system): Use as example the CDO Server launch, an add a port for the -console parameter. Connect to the console with putty or windows telnet (with the default properties). On both you will see the OSGi - help informations are formated clean, the CDO and Net4j help are not. In putty you can change the property: Terminal -> Implicit CR in every LF , than you get also a clean formated output. For this bug I've looked into the code from the org.eclipse.core.internal.registry.osgi.RegistryCommandProvider from org.eclipse.equinox.registry.osgi bundle. This and also all other "default available CommandProviders" from the reference hierarchy of CommandProvider uses the "\r\n" as line break. So I think that the "\r\n"-linebreak will work also under linux systems. If the Net4j and CDO contributions to the console really behave differently from the othzers then we should certainly fix this. Thanks for pushing on this ;-) commit 8ecec02da7f74d57b0e7425adfb854e75bc6c221 Port to 4.1 via bug 377108. Closing. |
Created attachment 210059 [details] Git Patch of org.eclipse.emf.cdo.server Currently in the help message is "\n" used as a line break. In Windows (telnet, putty), these line breaks are not executed cleanly and as a result you get a wild-shifted display of the commands. This is where the line breaks expand to "\r\n". I hope my first attempt with Git patch is useable. Greetings Heiko