Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369672

Summary:	[client] Git log: tagging failed but no error was displayed
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Git	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys, tomasz.zarna
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Malgorzata Janczarska

2012-01-25 10:14:03 EST

Open a git log and try to use "add tag" option, but make sure you can't add the tag (for any reason).
I got 500 error saying that my tag was rejected [GOOD], I have this information in logs, but there is no error information on UI.

Comment 1 Malgorzata Janczarska

2012-01-25 10:15:40 EST

There is also an error in javascript:
TypeError: item is undefined
(undefined="(void 0)")explorer.js (line 160)

Comment 2 Malgorzata Janczarska

2012-02-06 11:45:57 EST

Fixed. There where more than one errors here:
1. Even if adding tag failed it was the callback, not errback called (fixed by previous changes in gitClient)
2. When adding tag succeeded the view wasn't refreshed correctly.
3. New tag input on git log was displayed in the wrong column and there was also an attempt to add a tag to the wrong column.

After correcting all this everything works as it used to.