Bugzilla – Full Text Bug Listing
| Summary: | FormsPlugin (Activator) unnecessary extends AbstractUIPlugin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tom K. <spam> | ||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | bugs.eclipse.org, Lars.Vogel, pwebster, remy.suen | ||||
| Version: | 4.2 | Keywords: | helpwanted | ||||
| Target Milestone: | 4.3 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Can we get somebody checking this ? Would be great... Created attachment 216822 [details]
simplify FormsPlugin
(In reply to comment #2) > Created attachment 216822 [details] > simplify FormsPlugin Is that getContext() method actually needed? I suspect not ... I'll remove it when we look at this in 4.3 and if it still compiles ... ta da! PW Is this something we want to do for Eclipse 4.3? I won't have time to look at it, but if you want to test it out and submit a Gerrit change we can pull it in. PW https://git.eclipse.org/r/#/c/11423/ has Paul's patch + Remy's suggestion to remove getContext() As per Brian de Alwis request... 1. I have authored 100% of the content I'm contributing Yes (see my comment #7) 2. I have the rights to donate the content to Eclipse Yes 3. I contribute the content under the EPL Yes Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c4f3c7b9c369b21593fc500e7fcac268f701847 Thanks Markus PW In 4.3.0.I20130516-2200 PW |
Build Identifier: I20120103-1230 The plugin org.eclipse.ui.forms has an optional dependency on org.eclipse.ui. This is great since because of that you can use for e4 rcp clients the most of the forms api without depending on org.eclipse.ui But... Since the activator (org.eclipse.ui.internal.forms.FormsPlugin) is extedning AbstractUIPlugin the declared optional dependency gets an implicit required dependency. Proposal: Rewrite org.eclipse.ui.internal.forms.FormsPlugin to implements BundleActivator instead of extending AbstractUIPlugin. ------------------------------------------------------------- package org.eclipse.ui.internal.forms; import org.eclipse.ui.internal.forms.widgets.FormsResources; import org.osgi.framework.BundleActivator; import org.osgi.framework.BundleContext; public class FormsPlugin implements BundleActivator { private static BundleContext context; static BundleContext getContext() { return context; } public void start(BundleContext context) throws Exception { FormsPlugin.context = context; } public void stop(BundleContext context) throws Exception { FormsResources.shutdown(); FormsPlugin.context = null; } } ------------------------------------------------------------- Reproducible: Always