Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369580

Summary:	Open resources dialog does not find any images
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Server	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw
Version:	0.4
Target Milestone:	1.0 M1
Hardware:	PC
OS:	Mac OS X
Whiteboard:
Bug Depends on:	386516
Bug Blocks:	383483

Description Andrew Eisenberg

2012-01-24 14:37:14 EST

To reproduce:

1. Check out orion source code in an orion instance
2. Open the Open resources dialog
3. search for *.gif
4. Nothing shows up even though there are multiple in the orion.core/web/images directory.

Same behavior with *.png and *.jpg.

It occurs to me that this may be by design since Open resources may only be looking for text files (or files with known content type), but in the case I was going for, I would be happy to just be able to click on the link to the image and see it in a new browser tab (or maybe the same one).

Comment 1 John Arthorne

2012-01-24 15:00:51 EST

Hmm, it is by design that our lucene indexer is only attempting to index text files, but for binary files we could create a single index entry for doing name searches like this.

Comment 2 John Arthorne

2012-04-20 16:54:18 EDT

This is a simple change on the server, but when I tried it, it attempted to open binary files in the editor, which is broken. This needs the same logic as the navigator to figure out whether to open a link in the editor or just as a raw link.

Comment 3 John Arthorne

2012-08-02 09:42:41 EDT

I have pushed this change to master:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=e7dcb9899e8094d174264cdf1e65e2b871de19f8

Still need to have the client side logic changed so it doesn't attempt to open editor on these files. Maybe default action is just open navigator on that directory.

Comment 4 libing wang

2012-08-03 15:54:14 EDT

I think the fix of bug 386516 is good enough for M1.
I opened Bug 386598 for a generic solution as a common pattern for other places such as favorite list,etc.

Comment 5 John Arthorne

2012-08-03 16:36:57 EDT

Thanks Libing. Marking fixed for M1.