Bugzilla – Full Text Bug Listing
| Summary: | Rich UI proxy optimization - don't spawn a thread for each service invocation | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Joseph Vincens <jvincens> |
| Component: | EDT | Assignee: | Joseph Vincens <jvincens> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | chenzhh, jinfahua, margolis, smythew, svihovec, tdramsey |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | RUI_Optimization | ||
|
Description
Joseph Vincens
Timeout was added way back in CE. The implementation reads the data in a thread thread and the main thread handles the timeout. We currently don't support timeout as an annotation, a user has to add a header value to the service invocation request to set the timeout. ~50% of the RBD applications I see use timeout so we may want to support the annotation. The HTTP connection object we are using has a read timeout but it says:"Some non-standard implementation of this method ignores the specified timeout." and it gives a way determine if it's supported. To support Google App Engine we can't spawn a thread so the simple solution is to use the read timeout. If HTTP connection is a non standard HTTP connection that does not support the timeout and someone tries to use a timeout we will throw an exception stating timeout is not supported. review results. The proxy will no longer spawn a thread to support a connection timeout. The proxy will use the HttpURLConnection.readTimeout to support timeouts. The HttpURLConnection.readTimeout says "Some non-standard implementation of this method ignores the specified timeout" At runtime the code checks if readTimeout is supported if it is not an exception is thrown "The environments HttpURLConnection does not support timeout." I have tested with Sun and IBM JDK as both support the readTimeout. RBD has a timeout annotation that can be put on the service invocation call statement. EDT does not have support for the timeout annotation. If the user requires a service invocation timeout they need to set a header value with the timeout value. The timeout key is edt.proxy.invocation.timeout and the value is the number of seconds to wait (this is different than RBD it specifies the number of milliseconds).
Example:
srvc Service1?{@Resource};
http any = srvc;
(http as HttpRest).request.headers = new dictionary;
//set a 6 second timeout
(http as HttpRest).request.headers["edt.proxy.invocation.timeout"] = 6;
ServiceLib.completeBind(srvc, http);
call srvc.hello("some text") returning to handleResponse onexception handleException;
removed thread and changed code to use read timeout FVT test: the service eunit tests will check for regression. To test the actual non threading follow the link below 364666 and a Google engine app will need to be written. I deployed a simple Hello World app (with a service) to Google App Engine and it worked properly. So, looks like we have a good fix! will has verified this |