Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369528

Summary: [Min/Max] Welcome screen incorrectly sized
Product: [Eclipse Project] Platform Reporter: Oleg Besedin <ob1.eclipse>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: emoffatt, remy.suen
Version: 4.2   
Target Milestone: 4.2 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot none

Description Oleg Besedin CLA 2012-01-24 10:02:46 EST
Created attachment 209969 [details]
screenshot

On a new workspace:
- close the initial Welcome screen 
- change to CVS perspective
- Help -> Welcome

Note that the Welcome screen covers only secondary navigation area but the whole screen is blank. (See the attached screenshot.)
Comment 1 Oleg Besedin CLA 2012-01-24 10:03:10 EST
That's on I20120123-2200.
Comment 2 Eric Moffatt CLA 2012-01-24 11:09:37 EST
This is the result of having two perspectives open...

The visibilityHandler in the CleanupAddon checks to see if there are any 'visible' children left in the parent of the element that has just gone invisible. When there are multiple perspectives open this check (of course) fails and leaves the PerspectiveStack in the presentation.

The fix here may be an explicit check for the MPerspectiveStack in the CleanupAddon...I'll check this out.
Comment 3 Eric Moffatt CLA 2012-01-24 13:20:07 EST
Pushed in >20120124.

commit 241d4e6cd9f9f7e0e82a720f6d3aafa515a067aa

Added the special check as per my initial comment
Comment 4 Eric Moffatt CLA 2012-01-24 13:20:22 EST
Marking FIXED.
Comment 5 Eric Moffatt CLA 2012-02-02 14:15:10 EST
Pushed in >20120202.

commit 2e2ed432ac4c623f2e3f7ccc80d7170307779d72

This is a fairly major change...I've replaces the earlier hacky code that worked for one perspective with a different approach that minimizes the whole MPerspectiveStack if a view outside the perspective is maximized. This is a much better approach since it better reflects what's actually going on in the model.

For now I've intentionally left the ability to use the min/max behavior within the perspective itself on (even though there's a maximized part outside the perspective you can still maximize its shared area for example...)
Comment 6 Eric Moffatt CLA 2012-03-13 11:28:25 EDT
Verified in I20120312-1730.