Bugzilla – Full Text Bug Listing
| Summary: | Creation of new SpecObjects in an empty Specification is not intuitive | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] MDT.RMF | Reporter: | Michael Jastram <michael> | ||||||||
| Component: | ProR | Assignee: | Michael Jastram <michael> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | critical | ||||||||||
| Priority: | P1 | CC: | christoph, eclipse, lukas.ladenberger | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | 0.6.0 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Jastram
*** Bug 374186 has been marked as a duplicate of this bug. *** The proposed solution is to allow right-clicking in the empty Editor. This already pops up a context menu, but with respect to the current selection. Instead, the parent Specification must be the selection that the context menu refers to. There is a similar Problem with the Column Configuration Dialog: If you create a new Specification Type there are no colums defined. In this case it is impossible to add new columns in the Column Configuration Dialog, since there are no Siblings to add to. Created attachment 225094 [details]
Proposed Patch - Part 1 of 3
Patch for Agile Grid - CellSelectionManager.java
Created attachment 225095 [details]
Proposed Patch - Part 2 of 3
Patch for ProrAgileGrid.java
Created attachment 225096 [details]
Proposed Patch - Part 3 of 3
Patch for ProrAgileGridViewer.java
Duplicate of Bug 397550, but not closed due to attached patches. Thank you for the contributions! - Patch 1 is great the way it is, I'll incorporate it on Sourcefoge into AgileGrid. - Patch 2 is not necessary, if parts of Patch 3 are applied: by setting the selection via ProrAgileGridViewer.registerSelectionChangedListener(), the menu will be based on the correct element. - Patch 3 points in the right direction, but does not work as shown here. Specifically, it does two things: Managing the selection and preventing flickering. The code for selection management has been simplified and implemented -thanks a lot. The code for preventing flickering prevents Drag and Drop to work properly (at least on my system), therefore I omitted it for the time being. To capture this, I opened Bug 397661. New SpecObjects can now be created by right-clicking in the empty Editor area. Comment on attachment 225096 [details]
Proposed Patch - Part 3 of 3
Any code added to the three files posted here was solely written by myself and I have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment on attachment 225096 [details]
Proposed Patch - Part 3 of 3
Set iplog+ in order to include this patch into the automatically generated ip log.
Comment on attachment 225094 [details]
Proposed Patch - Part 1 of 3
added iplog+ since the agilegrid (EPL) code is redistributed via RMF
Comment on attachment 225095 [details] Proposed Patch - Part 2 of 3 set iplog- since the patch was not required. See comment #8. The agile grid contribution went into the source forge repository of agile grid on 08.01.2013. The diff is available at: http://agilegrid.git.sourceforge.net/git/gitweb.cgi?p=agilegrid/agilegrid;a=blobdiff;f=org.agilemore.agilegrid/src/org/agilemore/agilegrid/CellSelectionManager.java;h=00259760239d59269d9f5288ec646f886ba84e8d;hp=0667580598ad3d992336cc61fdf6614865a8657f;hb=26cfb3c2bed613d6ad13be4fe5a731afed579621;hpb=76686fd468a1f87c3e117ed676627431fcec552b The fix was released by source forge as agile grid 1.3.1 and was checked via CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7042 Proposed patch 3 (ProrAgileGridViewer) was committed on 07.01.2013: http://git.eclipse.org/c/rmf/org.eclipse.rmf.git/commit/?h=develop&id=44d31dbd7465ca5383116e2f307dba0f9d07f3e4 9 lines of code added: no CQ required. |