Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369397

Summary:	[Search]Replace is broken.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, susan
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2012-01-23 10:14:05 EST

Build I20120122-2230.
Steps:
1.Search on a keyword.
2.In the result page, click on replace.
3.In the slide out, input replacing string.
4.Nothing happens.

Comment 1 libing wang

2012-01-23 10:45:56 EST

fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1c438307b4f315dfe56dcfcec1c5d725c6c3afdd.

Susan, I know it might not be a perfect solution but search result's "main paine" had to be a dojo boarder container in order to "hold" the replace preview at least for now.

Long time ago, compare widget had the same issue as well. I had struggled to inject a border container into any DIV but I had issues with the widget start up. It turned out that the parent DIV for the widget had to a border container.

But if you have successful use cases, please let me know.

Comment 2 Susan McCourt

2012-01-23 12:14:12 EST

Sorry, Libing!
That was mostly a cut/paste error I wasn't specifically trying to get rid of your BorderContainer.  I had made sure that search page worked, and tested the replace slideout, but since I hadn't used replace page before, I didn't test any further...

Comment 3 libing wang

2012-01-23 12:17:41 EST

Talked to Anton and he gave me some good ideas.
I will create a separate bug to resolve it generically for both compare widget and the preview widget.
Basically both of them should be able to be injected into any DIV.

Comment 4 libing wang

2012-01-23 12:20:12 EST

(In reply to comment #2)
> Sorry, Libing!
> That was mostly a cut/paste error I wasn't specifically trying to get rid of
> your BorderContainer.  I had made sure that search page worked, and tested the
> replace slideout, but since I hadn't used replace page before, I didn't test
> any further...

Susan, actually the accident was good reminder for me to make my widgets(both compare and preview) to be better.
Fixing it right now.

Comment 5 libing wang

2012-01-23 12:36:44 EST

I've opened and fixed Bug 369425. 
So now the search result main pane can be any DIV.