Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369371

Summary:

ConnectionDecorator visualization cut

Product:

[Modeling] Graphiti

Reporter:

Michael Wenz <michael.wenz>

Component:

Core

Assignee:

Project Inbox <graphiti-inbox>

Status:

ASSIGNED ---

QA Contact:

Severity:

normal

Priority:

CC:

christian.brand, fabio.filippelli, matthias.gorning

Version:

0.8.0

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

442483, 369220

Attachments:

Description	Flags
construction in sketch editor (free connection, with patched create functionality)	none
reproducable without zooming	none

Description Michael Wenz

2012-01-23 06:00:31 EST

This is a split off from Bug 369220, point 2.
We have a problem that the visualization of the decorating shape will
be cut if we move the start or end shape of the connection. Then the angle
changes and the shape (e.g. ellipse) will be cut at a border. If the shape is
bigger or the zoom is activated this problem will occur more frequently.
See following example code for reproduce it and the two appended files in the
zip.

ConnectionDecorator decorator =
peCreateService.createConnectionDecorator(newConnection, false, 0.5, true);
Ellipse ellipse = gaService.createEllipse(decorator);
gaService.setLocationAndSize(ellipse, 1, 9, 150, 150);

Here's th link to the original attachment that shows the cut:
https://bugs.eclipse.org/bugs/attachment.cgi?id=209816

Comment 1 Christian Brand

2012-04-26 03:32:47 EDT

Created attachment 214580 [details]
construction in sketch editor (free connection, with patched create functionality)

Comment 2 Christian Brand

2012-04-26 03:33:16 EDT

Created attachment 214581 [details]
reproducable without zooming

Comment 3 Christian Brand

2012-04-26 11:40:25 EDT

we are close to a solution

Comment 4 Christian Brand

2012-04-27 08:29:59 EDT

commit 7c0a2c7bed07543288c31f46eb522371393da466
Author: cbrand <christian.brand@sap.com> 2012-04-26 18:23:35
Committer: cbrand <christian.brand@sap.com> 2012-04-26 18:23:35
Parent: 9d34b22b228cb4409055191435d4064574c2132e (Bug 369371 - ConnectionDecorator visualization cut)

Comment 5 Matthias Gorning

2012-05-07 07:28:19 EDT

The problem still exists.

It's reproducible in the sketch sample. Add the following lines to the execute method of the ToggleDecorator feature:

decorator = pecService.createConnectionDecorator(connection, false, 0.5, true);
Ellipse e = gaService.createEllipse(decorator);
e.setForeground(manageColor(IColorConstant.DARK_BLUE));
Graphiti.getLayoutService().setLocationAndSize(e, 0, 0, 150, 150);

Then create two nodes and connect them with a freeform connection. Move the nodes around and you will see that parts of the ellipse will be cut.

Comment 6 Michael Wenz

2012-05-22 09:00:54 EDT

Some improvements have been implemented for Juno M7, but the bug is not completely fixed. To really fix the remaining issues larger changes would be necessary that appear too dangerous for the RC phase and the rather exotic case in which the bug appears.
Postponed to post-Juno.

Comment 7 Michael Wenz

2012-08-21 09:48:42 EDT

Added for Kepler

Comment 8 Michael Wenz

2012-11-29 10:41:39 EST

Marked as optional for Kepler due to limited capacity