Bugzilla – Full Text Bug Listing
| Summary: | [DB4O] Performance reports should be logged via a Tracer, not via OM.LOG | ||
|---|---|---|---|
| Product: | [Modeling] EMF | Reporter: | Stefan Winkler <stefan> |
| Component: | cdo.core | Assignee: | Victor Roldan Betancort <vroldanbet> |
| Status: | CLOSED WONTFIX | QA Contact: | Eike Stepper <stepper> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | vroldanbet |
| Version: | 4.8 | Flags: | vroldanbet:
review+
stepper: review+ |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
Committed to branch bugs/369364 and pushed to origin commit f85b87a594f305e9af59c514163c38432731a667 Author: Stefan Winkler <stefan@winklerweb.net> 2012-01-23 11:09:51 Committer: Stefan Winkler <stefan@winklerweb.net> 2012-01-23 11:09:51 Parent: ed56b1db68e515861afb0afce574106f7191bb04 (On Hudson run only the DB/H2 tests) Branches: origin/bugs/369364, bugs/369364 [369364] [DB4O] Performance reports should be logged via a Tracer, not via OM.LOG https://bugs.eclipse.org/bugs/show_bug.cgi?id=369364 Vik, can you please have a look. Maybe measuring the time of storing one single revision does not really need to be measured, as it is always 0 or 1 millisecond on my machine. So maybe the measuring code should be eliminated from writeRevision completely …. Stefan, the patch looks good. Those traces are now probably not useful, I assume they were in the past. You can safely remove them. If necessary, they can be added while doing performance tunning of profiling. Hi Stefan, is it possible to mark as fixed this bug already? Ah, this isn't committed to master yet. I could merge that, if you want. Guys, what's the status of this bug? AFAIK, there is a branch created, but the code is not merged. I think Stefan suggested to add some additional changes before merging. Sorry for the late reaction. Vik, please decide if you still need the log entry in protected void writeRevision(InternalCDORevision revision, OMMonitor monitor) (DB4OStoreAccessor lines 692 and 700) because it seems too fine-granular to me (outputs 0 or 1 millisecond for me all the time) If you still need it, please merge the branch and resolve the bug. If you don't need it, please remove the logging at the indicated position and then merge and resolve. Thanks ;-) Go ahead... Moving all open issues to 4.2. Open bugs can be ported to 4.1 maintenance after they've been fixed in master. Moving all outstanding enhancements to 4.3 Moving all open enhancement requests to 4.4 Moving all open enhancement requests to 4.4 Moving all open bugzillas to 4.5. Moving all unaddressed bugzillas to 4.6. Moving all open bugs to 4.7 Moving all unresolved issues to version 4.8- DB4O support has been deprecated, see bug 552307. |
DB4OStoreAccessor contains several performance measurement reports such as OM.LOG.debug("Commit took -> " + (end - start) + " milliseconds"); This leads to a lot of unwanted log output in production settings. Therefore these statements should be replaced by tracing, which can be enabled and disabled as needed.