Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369347

Summary:	preferences page - visual nits
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Anton McConville <antonm>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-22 16:40:54 EST

- I think the selection color on the categories bar is too bright.  We can have Linda (graphic designer) look at it but in the meantime I think we should use the navigator selection color (a darker gray).  You could use ide.css .checkedRow as the class (but we could rename it to something like .selectedItem)

- the cursor on the categories list is an i-beam not a pointer, so it's not clear that you can select something.  (especially initially when nothing is selected, it can be confusing.)

- I think the use of the "orion dots" as the default plugin icon is a cool idea but I think we should use the rgb color from the logo (darker).  The current one is very bright and kind of clashes with the other colors.  We can also request that an icon be designed...(what do you think?)

Comment 1 Susan McCourt

2012-01-23 17:31:16 EST

Thinking about it some more:
- I think that the heading that says "Categories" is not really needed.  The page title says "Settings" and I think the nav elements are self explanatory.

- We should have a splitter bar so the user can adjust the left/right position

- Rethinking the selection color....I wonder how white would 
look?  It might make it look more integrated with the content on the right (though the splitter might interfere with that).  Just a thought.  Will still have Linda look at it.

Comment 2 Anton McConville

2012-01-24 13:16:13 EST

I have fixes for the selection color - I took the .checkedRow color - white didn't seem visually appealing. I like this checkedRow color - subtle yet obvious which is selected, I think it works fine for now.

Changed the cursor

modified the Orion dots - I sampled the logo color and made some initial plugin icons with plugs in them. We can request a more professionally designed logo for sure.

As for the other comments, please can we address them as we evolve the plugins feature? I'd like to think about the title - it plays a little bit of a role in the JSON definition - so I'd like it there as a clue/guideline for now, and also, can we tackle the re-sizable partition when we have more content and so need it - I'd rather this work item didn't turn into a growing list of tweaks :) I think we're at a good starting point, and I'd like to focus on some other items that I think could be a bit more useful for now. 

https://github.com/antonmc/orion.client

Comment 3 Susan McCourt

2012-01-24 16:01:50 EST

The changes look great!  This is definitely an improvement and the icon will be fine.  I will have a designer look at it stylistically but it's certainly good enough!

(In reply to comment #2)

> As for the other comments, please can we address them as we evolve the plugins
> feature? I'd like to think about the title - it plays a little bit of a role in
> the JSON definition - so I'd like it there as a clue/guideline for now, and
> also, can we tackle the re-sizable partition when we have more content and so
> need it - I'd rather this work item didn't turn into a growing list of tweaks
> :) 

Ha!  The sooner you fix the bug the sooner I have to stop adding to it!  I understand.

Perhaps we can address the splitter and heading part in bug 368848 when we have more instances of the pattern.  I agree with not using it til the content warrants, but if we use this pattern in other places (like repo page) I could definitely see the need.