Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369306

Summary: PluginConverter.convertManifest javadoc ask for a directory when archives are supported
Product: [Eclipse Project] Equinox Reporter: Curtis Windatt <curtis.windatt.public>
Component: FrameworkAssignee: Thomas Watson <tjwatson>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tjwatson
Version: 3.7   
Target Milestone: Juno M5   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Curtis Windatt CLA 2012-01-20 18:30:23 EST 
org.eclipse.orgi.service.PluginConverter

Both convertManifest() methods ask for a directory:
"Converts a plug-in/fragment manifest at the given source base location (a directory)..."

I think this is what led PDE to not support non-osgi plugins in target platforms around 3.4 (bug 368753).

Investigating and testing the code, it appears to read archive files (jars/wars) correctly.

Please update the javadoc so we don't make the same mistake again :)
Comment 1 Thomas Watson CLA 2012-01-23 09:09:13 EST 
I will fix the javadoc.