Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 36929

Summary: Attempt to put my Step menu with Step/Return has side-effect of changing Eclipse's Step/Return position in menu
Product: [Eclipse Project] Platform Reporter: Marcio <mqm>
Component: DebugAssignee: Platform-Debug-Inbox <platform-debug-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: n.a.edgar, simon_arsenault
Version: 2.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Plugin that illustrates the problem none

Description Marcio CLA 2003-04-25 14:59:14 EDT 
While attempting to put my own Step/special menu option just under Eclipse's 
Step/Return, what happened was that Eclipse's Step/Return was moved into my 
group/location.

Chances are my definition is wrong, but should I be able to change the 
location of the existing menu option??? Shouldn't Eclipse protect against 
that ?

See attached plugin file (will attach after commiting this text).
Comment 1 Marcio CLA 2003-04-25 15:01:26 EDT 
Created attachment 4707 [details]
Plugin that illustrates the problem

Run and see the Step/special menu under Run in the debug perspective, and how
Step/Return is with it.
Comment 2 Darin Swanson CLA 2003-04-25 15:23:53 EDT 
The stepReturnGroup is defined as a groupMarker in the plugin.xml for the Debug 
UI plugin.

This seems wrong to me as well.
Nick can you comment on what we are seeing? Thanks.
Comment 3 Marcio CLA 2003-04-25 15:30:40 EDT 
I'd be interested to know what I need to change in my plugin to make my Step 
appear together with Step/Return, without this bad side-effect. Thanks in 
advance.
Comment 4 Nick Edgar CLA 2003-05-05 15:47:04 EDT 
Action sets are processed in the order of action set ids.
So the action set with id="com.sglebs.SglebsActionSet" is processed 
before "org.eclipse.debug.ui.debugActionSet", and ends up implicitly adding 
the "stepReturnGroup" group first.  The only workaround is to change your 
action set id to be greater than Debug's.

CC'ing Simon for confirmation.
Comment 5 Simon Arsenault CLA 2003-05-05 16:18:48 EDT 
Nick's comment is correct.
Comment 6 Darin Swanson CLA 2003-05-05 16:45:32 EDT 
Marcio, you will have to change your action set id as indicated by the UI 
committers.
Comment 7 Marcio CLA 2003-05-05 16:59:15 EDT 
Thanks Darin (and the others). I have to say this fix (workaround) feels like a 
hack to me as a plug-in provider though. The definition of groups should 
respect the plug-in pre-req chain, and not the alphabetical ordering of ids. 
Sigh. Oh well... Thanks anyway.
Comment 8 Darin Swanson CLA 2003-05-05 19:11:35 EDT 
Marcio,

You can always log your last comment as a enhancement against platform ui.
Comment 9 Nick Edgar CLA 2003-05-06 09:43:18 EDT 
Yes, it is a hack, and it's an issue we're aware of.  See bug 16282.