Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369278

Summary:	RPM proposal list thread may not have exited when asked to return value
Product:	[Tools] Linux Tools	Reporter:	Severin Gehwolf <sgehwolf>
Component:	RPM	Assignee:	Alexander Kurtakov <akurtakov>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	linux.rpm-inbox, overholt, sgehwolf
Version:	0.9.0	Flags:	sgehwolf: review+
Target Milestone:	1.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Severin Gehwolf

2012-01-20 14:27:14 EST

I've seen this a couple of times today:

!ENTRY org.eclipse.core.jobs 4 2 2012-01-20 14:08:20.251
!MESSAGE An internal error occurred during: "Update RPM packages proposal list".
!STACK 0
java.lang.IllegalThreadStateException: process hasn't exited
	at java.lang.UNIXProcess.exitValue(UNIXProcess.java:188)
	at org.eclipse.linuxtools.rpm.core.utils.BufferedProcessInputStream.getExitValue(BufferedProcessInputStream.java:44)
	at org.eclipse.linuxtools.rpm.ui.editor.RpmPackageBuildProposalsJob.retrievePackageList(RpmPackageBuildProposalsJob.java:176)
	at org.eclipse.linuxtools.rpm.ui.editor.RpmPackageBuildProposalsJob.run(RpmPackageBuildProposalsJob.java:60)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

In a nutshell, the code doesn't check if the process has exited before it is asked to return a the return value of the underlying process. I'll submit a patch for review shortly. Thanks.

Comment 1 Severin Gehwolf

2012-01-20 14:40:09 EST

Here is a proposed patch:

https://github.com/jerboaa/linuxtools/commit/4f2de0d9b5068116fb612be3af874d847843e0b6

Could you have a brief look? Thanks.

Comment 2 Severin Gehwolf

2012-03-10 18:57:50 EST

*** Bug 366816 has been marked as a duplicate of this bug. ***

Comment 3 Alexander Kurtakov

2012-03-12 07:39:44 EDT

Severin,
The patch looks good, please push it.

Comment 4 Severin Gehwolf

2012-03-12 16:15:31 EDT

Pushed. Commit 5ef63e5c18275f22bfcfac7fddd70fd0567b5e5c.