Bug 369272

Comment 1 Andrew Overholt 2012-01-20 13:53:29 EST

I've committed the bundle and added it to feature.set1's feature.xml.

Is it customary to leave Orbit bugs open until the bundle appears in a build?

Comment 2 David Williams 2012-01-20 13:57:29 EST

Not sure there is much of a custom, but think most marked as fixed once they make a change, and would reopen if problems. 

Don't forget to mark the "target milestone" where its expected to first appear.

Comment 3 Andrew Overholt 2012-01-20 14:10:41 EST

Resolving for now.  We can re-open (or open new issues) if there is a problem.

Comment 4 David Williams 2012-01-27 15:47:54 EST

Reopening, as you have forgotten the xml file that needs to go in

/org.eclipse.orbit.releng/ip_logs

This is especially important since it is an easy way for others to find the CQ to use when they say "use from orbit" in their CQ requests. 

Whoops! Worse! You say "approved for Orbit inclusion in CQ 5928" but that appears to be the CQ for Linux tools to use the third party package. 

Was there (is there) a CQ to "add to Orbit"? 

As a refresher ... one project must initially request to use the package (via a CQ as you did for LinuxTools). Once that's approved, a CQ can be opened by an orbit committer to "add to orbit", piggy backing on the first one. Once that's a approved, it can be added to Orbit. From then on, other projects can/should "piggy back" on the Orbit CQ. 


I was just noticing today there are issues with what's displayed on the Orbit download page (bug 369939) and then it had come up in another CQ: 
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5997

Comment 5 Andrew Overholt 2012-01-27 16:02:23 EST

(In reply to comment #4)
> Reopening, as you have forgotten the xml file that needs to go in
> 
> /org.eclipse.orbit.releng/ip_logs

I didn't do it because it doesn't appear to be listed here:

http://wiki.eclipse.org/Adding_Bundles_to_Orbit

> Was there (is there) a CQ to "add to Orbit"? 

Sorry, I missed the second "add to Orbit" CQ step here:

http://wiki.eclipse.org/Adding_Bundles_to_Orbit#Before_You_Do_Anything

Comment 6 Andrew Overholt 2012-01-27 16:40:05 EST

ip_log file added for SWTChart.

I noticed when adding this that I somehow fat-fingered the branch name and used "v_0_7_0" instead of "v0_7_0" ... should I fix that (how?) or just leave it?

Comment 7 David Williams 2012-01-27 17:00:09 EST

(In reply to comment #6)
... should I fix that (how?) or just leave it?

I would just leave it. Close enough not to be too confusing, IMHO.

Comment 8 Andrew Overholt 2012-01-27 17:36:09 EST

(In reply to comment #7)
> (In reply to comment #6)
> ... should I fix that (how?) or just leave it?
> 
> I would just leave it. Close enough not to be too confusing, IMHO.

Okay, thanks.

Should we close this or wait for a build which includes the ip_log addition?

Comment 9 David Williams 2012-01-27 18:04:59 EST

I think the typical workflow is to close "after the work is done" (and, technically, could 'verify' after the build is done, but not many do that, at least in Orbit). 

And, the build did just finish, and the table's entry looks good to me.