Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369263

Summary:	[Search]Title bar and option improvement.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, ken_walker, susan
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	369147

Description libing wang

2012-01-20 12:40:46 EST

Talked to John A and Ken this morning about the look&feel for the current search&replace pages.
Aside from bug 369147, we need some small changes for 0.4:
1.Remove the "replace all pages" commands from the tool bar.
2.Remove the "show as tree" option from the option menu.
3.Change the result page title to "Files 1-40 of 141 matching {search string} in".
4.Change the replace preview title to something like "replace {search string} by {replacing string} for files 1-40 of 141".
5.Fix some typos in the command name.(e.g. :repalce", "Wringting files")
6.If possible, make the replace command a slide out.
7.If possible, render the result files first and go to the file meta data round trip later. This will result in delayed rendering on greyed out files and location column.

Comment 1 Susan McCourt

2012-01-20 15:56:48 EST

Libing, regarding #3 and #4:
in my first round of header changes, I swapped the label info into the table header rather than the breadcrumb.  I'm trying to get all "page-level" info out of the title and somewhere else.  We may come up with a better/common place for pagination data, but I think it works for now.

I fixed the "writing files" typo because I happened to see it.

The slideout has changed to look like an expanding toolbar and this should play nicely.

If you want replace mode to be modal (click and you're done) then you can look in places like New File/New Folder (fileCommands.js) for how to setup the slideout.  You'll get it for free by requiring a text parameter.

If you want it to be modeless (stays open like find/replace does until dismissed) then you know where to look...basically you use the commandParameterCollector to do the work for you.

Comment 2 libing wang

2012-01-20 17:04:03 EST

8. In the replace preview page, we should also allow the scope down for replace.
   Clicking on the location will just scope down the replace with same replacing string.
9. In the replace preview page, we should also allow "next/previous page" to behave as replacing next/previous page.
   This means in the report page, you can easily replac

Comment 3 libing wang

2012-01-20 18:09:18 EST

Fix wiht http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2b630f3fe2737382a6825df945a77cb6d0eec1b1.

Bullet 7 is not fixed yet but I will consider that with bug 369147