Bugzilla – Full Text Bug Listing
| Summary: | Hardcoded dependency to IBM Java in or.eclipse.core.filesystem | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Krzysztof Daniel <krzysztof.daniel> | ||||||
| Component: | Resources | Assignee: | Krzysztof Daniel <krzysztof.daniel> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | krzysztof.daniel, remy.suen, sptaszkiewicz | ||||||
| Version: | 3.8 | ||||||||
| Target Milestone: | 3.8 M6 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Can you explain your changes to the OPT_FLAGS? Those changes are not substantial to the patch: (1)replacement of -O with -O2 this improves the level of code optimization (2) -g adds gdb debugging symbols. Created attachment 212056 [details]
Patch without additional changes
The remaining changes from the initial patch have now their own bug 373232. Krzysztof, can you also build natives? This patch doesn't affect the compiled natives so we don't need to produce new ones here. The patch just means the person calling make has to configure JAVA_HOME rather than having it configured in the makefile itself. Krzysztof, please submit the latest patch via Gerrit. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=371767. Krzysztof, my question about building natives is still valid. Just the part that requires new natives is moved to bug 373232. So let's talk there. Patch in gerrit: https://git.eclipse.org/r/5258 The patch has been released. I forgot to mark it as resolved. |
Created attachment 209805 [details] Fix proposition The plugin should not be dependent on any vendor. Ideally environmental JAVA_HOME should be used. Additionally, more optimization could be used.