Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369163

Summary:	Git Status link to editor
Product:	[ECD] Orion	Reporter:	John J. Barton <johnjbarton>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, susan
Version:	0.4
Target Milestone:	2.0 M2
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	359277, 369555
Bug Blocks:

Description John J. Barton

2012-01-19 19:34:07 EST

I was in git-status reviewing my changes using the compare panel. Oops: I need to change something. Now I need to get to the editor page for this file. 

How? I guess I have to open the Navigator in a new tab, remember the file path, drill down, open the editor on the file, forget what line I need to change, switch back to the git-status, note the line number, go back etc.

A link to the file along with the other buttons would be welcomed.

A link to the line from the diff line would be fantastic.

Comment 1 libing wang

2012-01-20 09:17:11 EST

(In reply to comment #0)
> I was in git-status reviewing my changes using the compare panel. Oops: I need
> to change something. Now I need to get to the editor page for this file. 
> 
> How? I guess I have to open the Navigator in a new tab, remember the file path,
> drill down, open the editor on the file, forget what line I need to change,
> switch back to the git-status, note the line number, go back etc.
For now, you can just open the side by side compare editor, where you can edit on the left side.

> A link to the file along with the other buttons would be welcomed.
Yes, will be convenient when you don't really want to go to side by side. Susan is consolidating item-oriented commands. @Susan, could you refer to a generic bug number as a reminder so that when I fix the bug I will follow that rule?
> A link to the line from the diff line would be fantastic.
Good idea. We may want to add another annotation ruler on the left of the view so you can click on to open the editor on that line..

Comment 2 Susan McCourt

2012-01-24 11:45:39 EST

*** Bug 347068 has been marked as a duplicate of this bug. ***

Comment 3 Susan McCourt

2012-01-24 11:51:56 EST

(In reply to comment #1)
> > A link to the file along with the other buttons would be welcomed.
> Yes, will be convenient when you don't really want to go to side by side. Susan
> is consolidating item-oriented commands. @Susan, could you refer to a generic
> bug number as a reminder so that when I fix the bug I will follow that rule?

I think you are talking about bug 359277.  I'm working on this today.

> > A link to the line from the diff line would be fantastic.
> Good idea. We may want to add another annotation ruler on the left of the view
> so you can click on to open the editor on that line..

Comment 4 John Arthorne

2014-12-23 10:06:37 EST

We have had this link in place for a long time now.