Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 369147

Summary: [Search]Remove the file content caching in replace preview
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, ken_walker, simon_kaegi, susan
Version: 0.4   
Target Milestone: 0.4 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 369263, 369460    
Bug Blocks:    

Description libing wang CLA 2012-01-19 15:45:11 EST 
Currently in the replace preview, all the file content and replaced content are cached. we should only cache the currently selected file.
Comment 1 libing wang CLA 2012-01-23 13:39:11 EST 
Aside from removing the preview cache, I am also considering rendering the search result faster.
Actually the server response for the search result is not bad.
The bad part is that I have to request file meta data for each file, where there are 2 reasons:
1.To render the location column I have to know the parent location.
2.To render a stale file without match, I have to know the file times-tamp.

A better solution would be server giving back those data but for now we should think about alternatives like:
Render the files right away. And request meta data after the explorer renders all file items.
@Susan,  I think currently I can just render file items as normal and location as empty at very beginning. Then in each response callback of the meta data, I modify the cells individually.(stales becomes grey and location cells as real links)
Comment 2 libing wang CLA 2012-01-23 18:22:28 EST 
the result page loading speed is improved in bug 369460.
Ready to remove the cache in preview now.
Comment 3 libing wang CLA 2012-01-24 19:00:13 EST 
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5a0930a314c07fe217e4df48a2b8a6dd53a3e696.
The loading speed of replace is much faster.