| Summary: | Submitted new task remained as unsubmitted task as well | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Thomas Ehrnhoefer <thomas.ehrnhoefer> | ||||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | eclipse, robert.munteanu, shawn.minto, steffen.pingel | ||||||||
| Version: | 3.6 | Keywords: | plan | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Thomas Ehrnhoefer
Created attachment 209770 [details]
the submitted but still local task editor
Wow, that's weird. I wonder if that's caused by submitting an empty description. Are you using the latest Mylyn head? No, it's using installed Mylyn 3.6.4 There was a description though (I just needed to redact it), so it's not an empty description thing I think. I think that I have seen this once or twice before and I think it happens when the server reports that the creation failed (i.e. message in the header but not logged) but it actually succeeded. The message in the header (of the still local task) was that it succeeded though. I clicked it, and it reported correct things (can't remember exactly what). *** Bug 371481 has been marked as a duplicate of this bug. *** I've been bothered enough by this to capture a wireshark trace of the conversation going on with the WineHQ bugzilla ( where this happens every time ). On a high level, I get the following calls: bc. POST /index.cgi ( user login ) -> HTTP/1.1 200 OK POST /post_bug.cgi ( bug creation ) -> HTTP/1.1 200 OK POST /show_bug.cgi ( bug load ) -> HTTP/1.1 200 OK The third call is more interesting . The id value of the bug is bc. id=zilla+%26ndash%3B+bug+30164&ctype=xml&excludefield=attachmentdata Bugzilla obviously complains about an invalid bug id bc.. <?xml version="1.0" encoding="UTF-8" standalone="yes" ?> <!DOCTYPE bugzilla SYSTEM "http://bugs.winehq.org/bugzilla.dtd"> <bugzilla version="4.0.2" urlbase="http://bugs.winehq.org/" maintainer="wine-bugs@winehq.org" exporter="robert.munteanu@gmail.com" > <bug error="InvalidBugId"> <bug_id>zilla &ndash; bug 30164</bug_id> </bug> </bugzilla> p. It looks like the the bug id is not extracted correctly. Created attachment 212660 [details]
The gzipped response received from the post_bug.cgi call
I think I found the reason for this problem. When we have an new bug we try to get the id from the <title> tag. In your case the title is <title>WineHQ Bugzilla – Bug ??? Submitted – summary</title> and not with the expected <title>Bug ??? Submitted – summary</title> When you change your customized template to <title>WineHQ – Bug ??? Submitted – summary</title> this will work. Reason is that we look for the first Bug substring in the title and assume that all between this and the Submitted is the bug id. In your case we get "zilla – Bug ???" as the id. Thanks for looking in this! Frank, the parsing and validation in the Bugzilla connector needs to be improved to handle this case more gracefully. Actual we use the following to extract the bug ID.
In the LanguageSettings we the following two list fields "submitted" and "bug". For the default this are
enSetting.addLanguageAttribute("submitted", "Submitted"); //$NON-NLS-1$ //$NON-NLS-2$
enSetting.addLanguageAttribute("submitted", "posted"); //$NON-NLS-1$ //$NON-NLS-2$
enSetting.addLanguageAttribute("bug", "Bug"); //$NON-NLS-1$ //$NON-NLS-2$
enSetting.addLanguageAttribute("bug", "Issue"); //$NON-NLS-1$ //$NON-NLS-2$
with the following Pattern:
{bug}bugID{submitted}
We have the following ways to fix this:
1) add an UI to change the LanguagSetting per repository so we change "Bug" to "WineHQ Bugzilla – Bug"
2) try to find the words from LanguagSetting "bug" in the substring when we the substring contains non numeric chars.
3) read only the numeric and whitespace chars before "submitted" and do no longer use "bug" in this place.
Thoughts?
Created attachment 213024 [details]
mylyn/context/zip
We are out of time for 3.8 to address this but we can take another look for 3.9. (In reply to comment #11) > We have the following ways to fix this: > 1) add an UI to change the LanguagSetting per repository so we change "Bug" to > "WineHQ Bugzilla – Bug" I'd prefer if we didn't complicate the repository settings further. > 2) try to find the words from LanguagSetting "bug" in the substring when we the > substring contains non numeric chars. That sounds reasonable to me. > 3) read only the numeric and whitespace chars before "submitted" and do no > longer use "bug" in this place. That seems like the best approach. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |