Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368950

Summary: Slow typing in big php files – (dltk) SelectionDispatchAction performance optimization
Product: [Technology] DLTK Reporter: Natalia Bartol <natalia.bartol>
Component: CommonAssignee: dltk.common-inbox <dltk.common-inbox>
Status: CLOSED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: alex.panchenko
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=368947
Whiteboard:
Attachments:
Description Flags
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread none

Description Natalia Bartol CLA 2012-01-18 07:32:52 EST 
Build Identifier: 

In org.eclipse.php.ui and org.eclipse.dltk.ui plugins
SelectionDispatchAction. selectionChanged(SelectionChangedEvent event) are responsible for enabling/disabling “Open type hierarchy”/”Open call hierarchy” based on what is currently selected in the editor. It would be good to execute those calls in non UI thread as it currently affects typing performance.


Reproducible: Always
Comment 1 Natalia Bartol CLA 2012-01-18 07:34:48 EST 
Created attachment 209673 [details]
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread

SelectionDispatchAction.dispatchSelectionChanged() wrapped in non UI job.
Comment 2 Alex Panchenko CLA 2012-01-18 07:43:40 EST 
I'll give it a try.
Comment 3 Natalia Bartol CLA 2012-01-18 11:31:59 EST 
I realised that there are few classes extending SelectionDispatchAction i.e. OpenCloseWorkingSetAction with methods that requires execution in UI thread. I'll create another patch just for OpenTypeHierarchyAction/OpenCallHierarchyAction classes.