Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368947

Summary:

Slow typing in big php files – enabling open type/call hierarchy action performance optimization

Product:

z_Archived

Reporter:

Natalia Bartol <natalia.bartol>

Component:

PDT

Assignee:

Natalia Bartol <natalia.bartol>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jacek.pospychala, silviya

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread	none
Enabling Open Type/Call Hierarchy Action moved to non UI thread - patch	jacek.pospychala: iplog+

Description Natalia Bartol

2012-01-18 07:19:59 EST

Build Identifier: 

In org.eclipse.php.ui and org.eclipse.dltk.ui plugins
SelectionDispatchAction. selectionChanged(SelectionChangedEvent event) are responsible for enabling/disabling “Open type hierarchy”/”Open call hierarchy” based on what is currently selected in the editor. It would be good to execute those calls in non UI thread as it currently affects typing performance.


Reproducible: Always

Comment 1 Natalia Bartol

2012-01-18 07:25:30 EST

Created attachment 209672 [details]
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread

SelectionDispatchAction.dispatchSelectionChanged(event.getSelection()) wrapped in non UI job.

Comment 2 Natalia Bartol

2012-01-18 07:36:22 EST

Related DLTK bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=368950

Comment 3 Natalia Bartol

2012-01-18 11:46:51 EST

Created attachment 209693 [details]
Enabling Open Type/Call Hierarchy Action moved to non UI thread - patch

Some classes that extend SelectionDispatchAction may contain methods that requires execution in UI thread, so attached patch changes only OpenTypeHierarchyAction and OpenCallHierarchyAction classes. Enabling action is moved to non UI job as it operates on AST and consumes some time.

Comment 4 Jacek Pospychala

2012-01-20 03:16:43 EST

fixed by Natalia

great work!

Comment 5 Natalia Bartol

2012-01-25 07:48:16 EST

Patch applied to HEAD by Jacek.

Comment 6 Sylvia Tancheva

2012-07-06 02:17:38 EDT

Verified. Closing
Ilina Stefanova