Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368897

Summary:	As a user, I would like to be able to add the current open file to the favorites list
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	susan
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Andrew Eisenberg

2012-01-17 18:53:11 EST

There is no way that I know of to add the current open file to the list of favorites.  I would like to have a keybinding for this.

When in the editor, the current file is added to favorites.  When in the navigator, the current directory is added to favorites.  When in repositories or sites ???

Suggested keybinding: 'F' in navigator and 'ESC F' in editor (see Bug 366445 for discussion on keybindings).

Comment 1 Susan McCourt

2012-01-18 11:39:46 EST

i'll add the keybinding suggestions to the other bug.
right now I'm working on a general infrastructure for "related" commands to start appearing across pages, and "make favorite" is part of this.

*** This bug has been marked as a duplicate of bug 360988 ***

Comment 2 Susan McCourt

2012-02-09 15:29:14 EST

reopening.  The "dup" bug was more general and will mostly get deferred, but I did get this going.

Comment 3 Susan McCourt

2012-02-09 15:32:56 EST

fixed.
I did not address keybindings yet as we still have to figure out our overall strategy.

What I did do:

On every orion page, you get a star icon.
For editor and navigator, it means add the current resource as a favorite.
For other pages, it adds the URL of the page you are on (so you can quickly get back to, say, git status on a particular repo, etc.)

There is lots of room for improvement, for example the URL itself is pretty ugly.  It'd be nice to have a name derived from page title and resource (like Git Status - org.eclipse.orion.client).  The user can rename this, which is good, and we can open new bugs for improvements.

The icon is going to be a little different than the normal fave icon (smaller to be less obstrusive in the header) and it is currently hard coded in globalCommands.js since we want different behavior than the standard make favorite command.  Long term it'd be nice to have only one "make favorite" command that handled the resource and URL case nicely together, generated user friendly name for a URL, etc.