| Summary: | CDT should force English messages from GCC | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Markus Milleder <Markus.Milleder> |
| Component: | cdt-build | Assignee: | cdt-build-inbox <cdt-build-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | Andrew Gvozdev <angvoz.dev> |
| Severity: | normal | ||
| Priority: | P3 | CC: | cdtdoug |
| Version: | 8.1.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Markus Milleder
For scanner discovery this was fixed with bug 368622, and your steps won't produce indexer errors anymore. You have a point with error parser but I am not convinced that forcing a different language on the user is a good idea. Anybody else has an opinion on that? (In reply to comment #1) > For scanner discovery this was fixed with bug 368622, and your steps won't > produce indexer errors anymore. > > You have a point with error parser but I am not convinced that forcing a > different language on the user is a good idea. Anybody else has an opinion on > that? I agree with you on that. We should be supporting non-English languages in everything we do, error parsing included. (In reply to comment #2) > (In reply to comment #1) > > For scanner discovery this was fixed with bug 368622, and your steps won't > > produce indexer errors anymore. Andrew, thanks for finding the bug report I was obviously too confused to find :-( > I agree with you on that. We should be supporting non-English languages in > everything we do, error parsing included. The error parser does not recognize translated warnings as warnings, adding them as errors in the Problems view. So, I'd like to ask for a build system warning if GCC's locale is non-English. I suggest detecting that by comparing the output of a gcc call without arguments between an invocation with default environment and one where the locale is set to "C". The best time to do so would likely be when doing discovery. (Compiling a test program that yields exactly 1 warning would yield the translation of "Warning", but writing such a program may be hard in the face of all the different GCC versions in common use.) Feel free to reclassify or even close this bug - it's certainly only either minor or an enhancement request now. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > For scanner discovery this was fixed with bug 368622, and your steps won't > > > produce indexer errors anymore. > Andrew, thanks for finding the bug report I was obviously too confused to find > :-( Heh, I actually meant bug 304139 where it was really fixed. > > I agree with you on that. We should be supporting non-English languages in > > everything we do, error parsing included. > The error parser does not recognize translated warnings as warnings, adding them > as errors in the Problems view. > So, I'd like to ask for a build system warning if GCC's locale is non-English. To detect that locale is non-English it would suffice to inspect environment variables. However, there is a variety of ways how one could support native locales. The official way is to translate eclipse by Babel project. Error parsers keep their patterns in property file that is supposed to be externalized by Babel. So could do it like that. I am not sure that that is most transparent to a user though. Another way from the top of my head is to provide "language packs" for error parsers, and ISV could easily do that. If one is serious about it, the one should spend some effort to design it well from both UI and code design perspectives. I doubt anybody plans to do that any time soon. In either case, a warning that locale is non-English is at odds with these potential solutions. > Feel free to reclassify or even close this bug - it's certainly only either > minor or an enhancement request now. Alright, I close it as WONTFIX. |