Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368875

Summary:	Clone Repository buttons inaccessible
Product:	[ECD] Orion	Reporter:	Max Li <maxli>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:	Carolyn MacLeod <carolynmacleod4>
Severity:	normal
Priority:	P3	CC:	maxli
Version:	0.3	Keywords:	accessibility
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	365361

Description Max Li

2012-01-17 15:10:58 EST

While using a screen reader and trying to clone a repository, the buttons after the URL for the repository cannot be tabbed to. While the Submit and Close actions can also be done with the keyboard (the Enter and Esc keys), the More Options is completely inaccessible.

Comment 1 Max Li

2012-01-19 10:38:22 EST

I have fixed this bug in the following repository in the accessibility branch.
https://github.com/max-li/orion.client.git

Comment 2 Max Li

2012-01-24 11:26:49 EST

This is the commit.
https://github.com/max-li/orion.client/commit/b7958ec377472142d6d997826c459cfea9cfb58e

Comment 3 Susan McCourt

2012-01-24 19:03:21 EST

Hi, Max.  I assumed that with this fix installed I would be able to tab from
the repository URL field to the buttons inside the slideout.  But it does not
work.  Am I misunderstanding the problem?

Tested on Chrome.

Comment 4 Max Li

2012-01-25 14:21:08 EST

It appears that JAWS makes it so that the original fix was sufficient, but
without JAWS it doesn't work. So I've updated the fix.

Here is the new commit (in the accessibility2 branch).

https://github.com/max-li/orion.client/commit/201b773c54e17c31a160a881b18ca80a21688853

Comment 5 Susan McCourt

2012-01-26 17:12:30 EST

Fixed.
I had just been working in this file so I merged the commit by hand.
While I was there I grouped a little bit of copied code into a function (I was embarrassed by how much copied code I have in there).

I also caught a case that was not fixed yet.  No way you could have known from looking at the code.  When using find/replace in the editor, the "cancel" button is generated in a different place (globalCommands line 96), so I applied your same solution there.

Thanks, Max!

My first attempt at grouping the code was not right, so I retested the keyboard access for all the buttons in these cases:
New Folder
Clone Repository
Editor Find Replace (go to editor and hit Ctrl+F while in the editor)

Would you mind retesting all those cases with JAWS to make sure I didn't screw up what you did?  Thank you!

Comment 6 Max Li

2012-01-30 09:09:34 EST

(In reply to comment #5)

> Would you mind retesting all those cases with JAWS to make sure I didn't screw
> up what you did?  Thank you!

Everything looks good.