Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368871

Summary: [Search]Add replace all js unit test on matches level.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, simon_kaegi
Version: 0.4   
Target Milestone: 0.4 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 371311    
Bug Blocks:    

Description libing wang CLA 2012-01-17 14:46:42 EST
The replace all is working now as a feature but it is still lacking a complete unit test.
For the replace all unit test, we should input:
1.A string of text contents.
2. A search keyword.
3. A replace string.
4.A list of index representing checked matches where we want to apply replace string.
5.Expected replaced content.

We should test on 
1. The in file search generates the expected result model.
2. The "new content generation" API generates the proper content representing the replaced file.
Comment 1 libing wang CLA 2012-02-17 15:26:32 EST
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d8d8bbc650d9354ebc18bcd5472190c59af3e666.

The code change happens purely in the js-tests folder and I confirmed that all cases passed. So I did not request a code review.