Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368869

Summary:	Page-specific command link bar is inaccessible
Product:	[ECD] Orion	Reporter:	Max Li <maxli>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:	Carolyn MacLeod <carolynmacleod4>
Severity:	normal
Priority:	P3	CC:	eclipse.felipe, maxli
Version:	0.3	Keywords:	accessibility
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	365361

Description Max Li

2012-01-17 14:32:05 EST

For a keyboard-only user, all the links in the page-specific command link bar (e.g. in the Navigator page, the New Folder and Link Folder) cannot be tabbed to and are thus inaccessible to this group of users.

Comment 1 Susan McCourt

2012-01-18 11:30:06 EST

see also bug 365362

Comment 2 Max Li

2012-01-19 10:38:57 EST

I have fixed this bug in the following repository in the accessibility branch.
https://github.com/max-li/orion.client.git

Comment 3 Felipe Heidrich

2012-01-24 11:18:35 EST

(In reply to comment #2)
> I have fixed this bug in the following repository in the accessibility branch.
> https://github.com/max-li/orion.client.git

complete link please

Comment 4 Susan McCourt

2012-01-24 11:28:21 EST

I can look at this.  Need link.
Also what branch are your fixes in?  (within Orion I don't know of a better workflow than git logging the branch to cherry pick the commit, does anyone have a better way)?

Comment 5 Max Li

2012-01-24 11:38:05 EST

Here is the commit (in the accessibility branch).

https://github.com/max-li/orion.client/commit/ddd1d45b677e85b41a9063c8239f66ed996eaa12

Comment 6 Susan McCourt

2012-01-24 18:58:46 EST

Hi, Max.  I assumed that with this fix installed I would be able to tab from the repository URL field to the buttons inside the slideout.  But it does not work.  Am I misunderstanding the problem?

Tested on Chrome.

Comment 7 Susan McCourt

2012-01-24 19:09:03 EST

(In reply to comment #6)
Please ignore comment 6, that was meant for a different bug.

I tested this fix and I don't think it is complete.
I can now tab to the "New File" and "New Folder" links, but pressing the Enter key doesn't cause them to be invoked.  We probably need to also assign a "button" role but I'm not sure.

Comment 8 Susan McCourt

2012-01-24 19:11:21 EST

*** Bug 368868 has been marked as a duplicate of this bug. ***

Comment 9 Susan McCourt

2012-01-24 19:13:42 EST

I'm pretty confused.  I'm seeing bugs that look like duplicates but seem to be fixing different aspects of the same problem.

Can you prepare one fix for this bug that would fix both the tab order and roles necessary to make the command links on the toolbars accessible?

As I understand it, this should require only fixes in commands.js.  It appears that aspects of the fix are in this commit, but not the button role.

Comment 10 Max Li

2012-01-25 14:18:37 EST

It appears that JAWS makes it so that the original fix was sufficient, but without JAWS it doesn't work. So I've updated the fix.

Here is the new commit (in the accessibility2 branch).

https://github.com/max-li/orion.client/commit/bd426c8dcc44a372a1e4f095d2fb82e245395722

Comment 11 Susan McCourt

2012-01-26 16:24:16 EST

(In reply to comment #10)
> It appears that JAWS makes it so that the original fix was sufficient, but
> without JAWS it doesn't work. So I've updated the fix.

How fun for you!  ;-)

> 
> Here is the new commit (in the accessibility2 branch).
> 
> https://github.com/max-li/orion.client/commit/bd426c8dcc44a372a1e4f095d2fb82e245395722

pushed to master.
tested on Chrome with Navigator page and Plugin page.
Thanks, Max!