Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368868

Summary:	Navigator New/Link Folder buttons/dialogs are inaccessible
Product:	[ECD] Orion	Reporter:	Max Li <maxli>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	CLOSED DUPLICATE	QA Contact:	Carolyn MacLeod <carolynmacleod4>
Severity:	normal
Priority:	P3	CC:	carolynmacleod4, eclipse.felipe, maxli
Version:	0.3	Keywords:	accessibility
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Max Li

2012-01-17 14:14:37 EST

While using a screen reader, if one invokes either the New Folder or Link Folder buttons, certain buttons on the resulting popup dialog cannot be accessed. For New Folder, both the Submit and Close cannot be tabbed to. However, it does appear that you can press Enter to submit and Esc to close, so not all functionality is lost. For Link Folder, you cannot close the popup with the close button, you must press Esc.

Comment 1 Max Li

2012-01-19 10:38:45 EST

I have fixed this bug in the following repository in the accessibility branch.
https://github.com/max-li/orion.client.git

Comment 2 Felipe Heidrich

2012-01-24 11:19:32 EST

(In reply to comment #1)
> I have fixed this bug in the following repository in the accessibility branch.
> https://github.com/max-li/orion.client.git

complete link please

Comment 3 Susan McCourt

2012-01-24 11:31:04 EST

link (and branch).
On the surface I would have expected this to be a duplicate of bug 368869 and not require its own fix.  I would think all command links could be handled with a signle fix in the command framework.  So I want to see all these fixes and make sure we are fixing in the right place.

Comment 4 Max Li

2012-01-24 11:39:41 EST

https://github.com/max-li/orion.client/commit/0fb5dd1aeb48863932cbb973c7a9564c62127ab6Here is the commit (in the accessibility branch).

https://github.com/max-li/orion.client/commit/0fb5dd1aeb48863932cbb973c7a9564c62127ab6

Comment 5 Susan McCourt

2012-01-24 19:11:21 EST


*** This bug has been marked as a duplicate of bug 368869 ***

Comment 6 Susan McCourt

2012-01-24 19:19:04 EST

As far as I can tell this bug duplicates aspects of both bug 368868 and bug 368875.  But none of the fixes seem complete.

I suggest get a fix in bug 368868 that addresses the link accessibility (commands.js) and get a fix in bug 368875 that addresses the button accessibility in the slideout (globalCommands.js).

I think both fixes both tab order and role setting, but what I'm seeing is fixes that do one or the other and thus I don't think the bugs are fixed yet.