Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368866

Summary: [Search]Replace improvements.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, susan
Version: 0.4   
Target Milestone: 0.4 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2012-01-17 14:11:20 EST
In Bug 344200 I mentioned replace was checked in.
Talked to John yes-today and we quickly went throught some typical work flows.
Here are some improvements we want to do for M2:
1.In the result page on the right of the replace input ,add two buttons:
  preview: this will invoke the same action as user hits enter in the input box
  force replace : this will replace everything without preview.

2.If there are multiple pages, replacing page by page will be confusing unless user understands there is a lag in the indexer.
For instance, if you've replaced everything on the first page and go to next page it may show you different matches depending how quickly you went there. 
We may also want some actions like "preview/replace all the pages" in one action.

3.Currently I am not using replace as the URL parameter but I think I should.
This means if you refresh the page at replace preview "mode" you will keep the replace mode.

4.The check boxes in the replace preview mode are made per matched line. But if there are multiple matches in a line, we should allow user to be able to check each match instead of each line.

5.Currently only files are click-able in order to bring up a compare widget.
  We should also allow user to click on each checked match and navigate the compare widget to that line. 

6.In the report page, there is a command called "done", we should rename it as "search again". This will bring user back to the result page.

7.The report page will not be a "page". It will just be a temporary state of the URL. Report state can be introduced by either preview page or result page, where if you use browser refresh it will just bring you back to "result" or "preview" state.
Comment 1 libing wang CLA 2012-01-17 14:13:57 EST
John, please add your comments if I am missing anything.
Comment 2 John Arthorne CLA 2012-01-17 14:26:41 EST
I think that covers everything. I will try it out and let you know if I find other issues.
Comment 3 libing wang CLA 2012-01-18 23:58:12 EST
fixed with 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=43cf5f127804ef34b43f5ad41c1050cedca7cb37

Everything is there now except the "force replace" I mentioned in bullet 1.
Implementation is not a big deal, just not sure if we want to introduce more commands:
We already have "replace current page" and "replace all pages". Not sure if we want " Force replace current page" and "Force replace all pages".