Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368852

Summary:	operations popup dismisses when dialog opens, can't read error
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-17 12:10:41 EST

I was cloning one of my github repositories and apparently used the wrong private key.  But I couldn't read the error message because it disappeared immediately, since the authentication dialog came back up immediately.

Note this is similar to the scenario in bug 347054 comment 2, except that in this case the failure is real.

Ideally...when the user hasn't typed credentials in yet, there should be no failure reported.  

When there is a true auth failure, the error needs to be reported in a non-transient way.

Comment 1 Malgorzata Janczarska

2012-01-19 04:25:22 EST

Too bad you will never get informed about wrong private key. All we get from git is "Auth fail" and it doesn't make any difference whether private key is wrong, password, missing passphrase or missing user and password.
I think I could try to keep the popup on top in this case but still all you would see would be "Auth fail". I'm not sure if this is helpful.

Comment 2 Szymon Brandys

2012-01-19 04:29:26 EST

I think we could just ignore the Auth Failed when no credentials were provided i.e. all credentials fields were empty and treat the Auth Failed as a real failure just when any credentials were passed. I think this is what Susan meant.

Comment 3 Malgorzata Janczarska

2012-01-19 04:51:57 EST

Sure, I can try to do that. But it's still not very helpful that all you can see in the error is "Auth fail".

Comment 4 Susan McCourt

2012-01-20 16:07:46 EST

I meant both.
If all we know is "auth fail" then that's all we can know.  But the popup flashed so fast I couldn't read it that it said "auth fail."
Also, as long as I have log full of fake "auth fail" errors when I haven't even tried to login, then I tend to distrust those errors.

So hiding the ones that the user didn't trigger and then being able to see the auth fail when it really happens should be good enough.

Comment 5 Malgorzata Janczarska

2012-01-23 12:01:17 EST

Try it out now.
I postponed popping out error for 10 milliseconds to allow caller to remove the operation. If operation is removed the popup is not displayed.
I am also removing Auth fail when the credentials popup is shown, not when the operations is renewed, so if you close the login popup you have no record about "Auth fail".

Comment 6 Malgorzata Janczarska

2012-01-24 08:13:03 EST

*** Bug 347054 has been marked as a duplicate of this bug. ***

Comment 7 Malgorzata Janczarska

2012-01-25 09:53:43 EST

I was playing with it for two days and I don't have any annoying pupup and also my operations list doesn't contain "Auth fail" at all. I think the fix done its job, so I'm closing this bug.
Susan, if you come across problems similar to described by this bug or Bug 347054, please reopen.

Comment 8 Susan McCourt

2012-01-25 13:34:50 EST

I don't recall seeing it recently either.  thanks.