Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368707

Summary:	[Incubator] Fix details in rwt.supplemental.fileupload
Product:	[RT] RAP	Reporter:	Rüdiger Herrmann <ruediger.herrmann>
Component:	Incubator	Assignee:	Project Inbox <rap.incubator-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ruediger.herrmann
Version:	1.4
Target Milestone:	1.5 M5
Hardware:	All
OS:	All
Whiteboard:

Description Rüdiger Herrmann

2012-01-16 08:11:08 EST

These thinks caught my eye me when looking at the o.e.r.rwt.supplemental.fileupload bundle:
* FileUploadDetails resides in a public package without reason
* IFileUploadListener is a listener-interface and therefore should not start with an 'I'

Comment 1 Rüdiger Herrmann

2012-01-16 08:29:10 EST

One more:
The IFileUploadListener should document that it isn't called from the UI thread, or otherwise be called from the UI thread.

Comment 2 Ralf Sternberg

2012-01-16 15:49:48 EST

I agree to all of your suggestions. Regarding the UI thread, I vaguely remember that there was the problem that the listener can be called without a context available, so I think 'd prefer to document the fact that it is not called from the UI thread.

Comment 3 Ivan Furnadjiev

2012-01-17 11:02:09 EST

Fixed all remarks in CVS HEAD.