Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368587

Summary:	orion.edit.command gets selection wrong when plugin returns text
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.3
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-13 15:31:36 EST

the code for orion.edit.command says that if you return only text, it will replace the selection with your text.  It gets the text part correct, but it keeps the editor selection at the same positions as originally. 

For example I wrote a plugin that replaces 191,191,191 with #bfbfbf and the selection ends up containing my returned text plus a few characters after (the selection length remains the same).

Comment 1 Susan McCourt

2012-01-13 15:32:35 EST

fixed.  Also fixed a bug where the editor keybinding was failing for contributed commands.