Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368580

Summary:	Refactor IDE runtime dependencies
Product:	[RT] Virgo	Reporter:	Miles Parker <milesparker>
Component:	tooling	Assignee:	Miles Parker <milesparker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse, leo.dos.santos, mlippert
Version:	unspecified
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:
Bug Depends on:
Bug Blocks:	368890

Description Miles Parker

2012-01-13 14:16:34 EST

Currently virgo.ide.runtime.ui has dependencies on org.eclipse.mylyn internals as well as zest. We should replace the mylyn internals (CommonImage) usage and factor zest into a seperate plugin.

The Zest dependendency should also probably be in a seperate optional feature, but we might handle that under another bug.

Comment 1 Miles Parker

2012-01-17 19:03:35 EST

Fixed, ridiculously easy. My official first Virgo contribution, assuming that -3 lines counts.

1) I have approval to submit this code
2) I (un-)wrote all of this code.

https://github.com/MilesParker/Virgo-Tooling/commit/a0323a289b74cfa8d7d9337556e148dd0ce909d1

Comment 2 Leo Dos Santos

2012-01-17 19:33:36 EST

Thanks Miles. Looks like the dependencies went away with the Libra contribution. You can view the checkin at http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=b6203008a2c2799d9eedbfc02acbf03537da521a

One note, I think it's best practice to keep the bug open until the committer has had the chance to merge the change in. Aside from that, congratulations on your first contribution to Virgo!

Comment 3 Miles Parker

2012-01-17 19:49:15 EST

Yeah, I had that realization about closing the bug and meant to correct but then promptly forgot it.