Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368574

Summary:	Content assist dialog does not close when there is a mouse click outside of the dialog
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Editor	Assignee:	Project Inbox <orion.editor-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Andrew Eisenberg

2012-01-13 13:34:00 EST

In the Orion editor, my expectation of how the content assist dialog should work is that it should close if there is a mouse click outside of the dialog.  However, the dialog does not close.  Rather, it stays open until a proposal is selected, escape is pressed, or there is a scroll.  This behavior is different from the Eclipse editor's behavior and just about any other IDE editor I can think of.

I will work on a patch for this.

Comment 1 Andrew Eisenberg

2012-01-14 17:39:18 EST

Created pull request on Github.  https://github.com/eclipse/orion.client/pull/10

This is my first contribution to eclipse using github, so please explain if there is something I should do differently.  I haven't seen any tests in this area, but I may have missed them.  Please let me know if you would like me to include a test and it would also be helpful to point me to an existing test that is similar to the one that I would create.

Comment 2 Mark Macdonald

2012-01-16 13:19:20 EST

(In reply to comment #1)
> Created pull request on Github. 
> https://github.com/eclipse/orion.client/pull/10

Hi Andrew,

Thanks for the patch. I reviewed and tested it, and it looks good.

> This is my first contribution to eclipse using github, so please explain if
> there is something I should do differently.

All I need is a confirmation from you that you wrote the code in the patch. You can reply here with a comment saying "I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use."

FYI, the full process for Git contributions is here: [1]

> I haven't seen any tests in this
> area, but I may have missed them.  Please let me know if you would like me to
> include a test and it would also be helpful to point me to an existing test
> that is similar to the one that I would create.

Yeah: the content assist UI component is lacking tests. Let's go ahead with this fix and I'll open a separate bug for the tests.

[1] http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions#Scenario

Comment 3 Andrew Eisenberg

2012-01-16 14:49:43 EST

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.

Comment 4 Mark Macdonald

2012-01-16 17:48:18 EST

Pushed:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=02781e080a6fefe5ec1ce1719a1b82327dcb91b5

Thanks again!

Comment 5 Andrew Eisenberg

2012-01-16 17:51:56 EST

Thanks for the fast turn around on this.