Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368556

Summary:

Backport to 3.2.x Last used editor should be set to SystemEditableRemoteFile

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

xuanchen

Version:

3.2

Flags:

xuanchen: review+

Target Milestone:

3.2.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

249031

Bug Blocks:

Attachments:

Description	Flags
backport patch for SystemEditableRemoteFile	none

Description David McKnight

2012-01-13 10:38:30 EST

This bug is for the backport of the fix for bug 249031 to the R3_2_maintenance stream.

Comment 1 David McKnight

2012-01-13 10:44:28 EST

The entire fix for bug 249031 (the changes for SystemViewRemoteFileAdapter.handleDoubleClick()) can't go into the maintenance stream since they require new unavailable APIs for SystemEditableRemoteFile however the change to use IDE.getEditorDescriptor() rather than the IEditorRegistry.getEditorDescriptor() needs to be done since it will have some required recent platform changes.

Comment 2 David McKnight

2012-01-13 10:57:51 EST

Created attachment 209459 [details]
backport patch for SystemEditableRemoteFile

Comment 3 David McKnight

2012-01-13 10:58:08 EST

Xuan, could you please review this patch?

Comment 4 Xuan Chen

2012-01-16 10:46:18 EST

The fix looks good.  Thanks.

Comment 5 David McKnight

2012-01-16 11:04:35 EST

Thanks Xuan.  I've committed the change to the R3_2_maintenance stream.